-
Notifications
You must be signed in to change notification settings - Fork 439
switch from poetry to uv #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mivanit
wants to merge
22
commits into
TransformerLensOrg:dev-3.x
Choose a base branch
from
mivanit:add-uv-and-check-docs
base: dev-3.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
switch from poetry to uv #1037
mivanit
wants to merge
22
commits into
TransformerLensOrg:dev-3.x
from
mivanit:add-uv-and-check-docs
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update link to Streamlit tutorial and guide. Co-authored-by: Bryce Meyer <[email protected]>
* add static to gitignore * making a meaningless change to see if tests pass at all * making a meaningless change to see if tests pass at all * add interactive table static html only adding things one at a time to see what causes things to break * run poetry update with no changes to deps * revert lockfile change * add tiktoken >=0.7.0 to group docs * add dep muutils >=0.6.15 to group docs * add improved interactive table generation we still generate a plain markdown table code is from the old PR: https://github.com/mivanit/TransformerLens/blob/add-better-model-properties-table/docs/make_docs.py which is in turn a modified version of https://github.com/mivanit/transformerlens-model-table * fix format -- missing trailing newline * fix type hints for compatibility * fix torch device meta in make docs script, also improved hot reload * TEMPORARY: allow_except when getting models to deal with mixtral HF_TOKEN issue * added simple test for get_model_info * context manager for controlling device, tests were breaking due to default device meta * formatted with wrong version of black, oops * fix path to generated model_properties_table * fix md table header, add title in yaml frontmatter * add line to frontmatter yaml, re-run tests bc huggingface down? * do not allow exceptions when getting models * re-run poetry lock * attempt fix lockfile * re-run poetry lock --------- Co-authored-by: Bryce Meyer <[email protected]>
also update tiktoken dep for 3.13 compatibility
- torchtyping causes various issues if it's imported - presumably jaxtyping should be used instead?? - othello GPT notebook doesn't actually use the imported TT - shouldn't a linter/formatter catch this sort of unused import?
Configure pytest to include project root in Python path, enabling `from tests.foo import bar` style imports, which were broken by switching to uv
ok, looks like nearly everything is passing! The few tests still failing:
remaining TODOs:
|
looks like building docs is failing due to a lack of a huggingface token secret? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs
pyproject.toml
makefile
checks.yml
release.yml
(changed this, but quite unsure whether what I did is a good idea. needs review for sure)README.md
contributing.md
.devcontainer/devcontainer.json
and.devcontainer/Dockerfile
to use uv instead of poetry. not sure how to do thisDescription
Poetry can be quite slow for dependency resolution and environment setup. uv is much faster and has rapidly become the new standard.
Type of change
Screenshots
raw timing data
All installs are tested with a warm cache (everything downloaded) and the virtual environment absent.poetry
lockfile present:
lockfile absent:
uv
lockfile present:
lockfile absent:
Checklist: