Cleanup definition of UNITY_COMPARISON_T in unity_internals.h #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unused values UNITY_WITHIN and UNITY_UNKNOWN update value UNITY_NOT_EQUAL
|
Hi Roland! Thanks for the improvements. I believe what you're looking at is a left-over of a refactoring which was started and not completely finished. It's left some remnants of things that are never called. I appreciate the cleanup! It's possible that one or either of these defines get re-added at some point as those other features might eventually get added... but it's best to clean it up now and let them be added IF needed. Also, IF they are added, they should be better thought out, clearly. Thanks for your continued support! |
|
Thanks for accepting the PR and the additional feedback. I enjoy using Unity & CMock in my daily professional work and I am willing to pay back at least a small dividend 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes for fixing #782 by removing unused values UNITY_WITHIN and UNITY_UNKNOWN and updating value UNITY_NOT_EQUAL