Detail-Stack API #775
Merged
Detail-Stack API #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ((label[0] == '#') && (label[1] != 0)) { | ||
| UnityPrint(label + 2); | ||
| UNITY_OUTPUT_CHAR(' '); | ||
| UnityPrintNumberByStyle(Unity.CurrentDetailStackValues[c], label[1]); |
There was a problem hiding this comment.
This function does not exist. It was renamed to UnityPrintIntNumberByStyle in #784 (ac52c41), but that also removed the implementation for printing with a style other than UNITY_DISPLAY_RANGE_INT.
Should this line be the following?
UnityPrintUintNumberByStyle(Unity.CurrentDetailStackValues[c], label[1]);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍍
Initial implementation for #774.
This adds
UNITY_DETAIL_PUSH/POP, which can be used to put arbitrary label+value pairs on the detail stack.The configuration is a bit complicated, but all labels are fully customizable.
Values can be either printed as string, or any of the supported number styles via special prefixes. See
examples/example_5for an example.Compared to the current detail slots (
CurrentDetail1/2, 2 x pointers), the overhead inUNITY_STORAGE_T(in RAM) is:I am open to any suggestions.