Net improvement cleanup #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on() and set_move_direction(). fixed 1 letter-off Personal menu area name. un-auto'd my code
Fix punk crash and download handshake
Allow component creation for more entity types and add is_counterable function
…ata. shaking fx is requeued if not in time freeze due to drag or applied earlier otherwise.
…ad' point in blind status used otherwise it is calculated from player height
… on chip art. Emotion window UI flicker speed adjusted. Fixed counters not appearing. Removed more auto's.
…t for swoosh::Timer which uses seconds. ESC key in battle must have app in focus to trigger. Tweaked some problems detecting and displaying combos and counter info text.
…n updates that serve to refresh the screen. Frame time objects replace swoosh timers.
…ut's in mob battle scene and network battle scene.
…s subtracted from the entity's health. updated sound font.
…her misc. Some of these need to be undone later.
… during time freeze.
…nloadScene handshake, aborts if version mismatch detected. Remove net logging from InputManager.
help sync softlocks on scene start and shouldn't desync because inputs are not being sent yet. Bump version.
…ra logging. Version increase.
…rting and ending. CustomBarProgress is now reset in CardSelectBattleState::onStart instead of the CombatBattleState. Version bump. The desync fixed was one where being decrossed during the turn and then not choosing a form on the following card select would cause the remote player to think you changed forms to the form at -1, which would animate and desync. SetCustomBarProgress call moved in order to prevent progress from resetting during transitions between combat and transformation state during combat, ,such as through decross. Transformation state should not be added as a subcombat state, so this makes more sense.
Pull changes made in net_test
TheMaverickProgrammer
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves netplay stability compared to the patch 5 release.
A few miscellaneous changes were made along the way:
There is code in this PR's history that would create a new log file for the Logger every time the DownloadScene is constructed. I've removed it from the current commit, because I wasn't able to test if the methods would work on other OSes, but it could be useful to look back on in the future.
NOTE: This PR has changes coming from development up until the patch 5 release. That includes up to 55d2c2f.
Additionally, code was picked out from the following commits on development, but they were not directly pulled: