-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Implementation of Negative Log Likelihood Loss Function #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
==========================================
+ Coverage 95.04% 95.06% +0.01%
==========================================
Files 305 307 +2
Lines 22674 22754 +80
==========================================
+ Hits 21550 21630 +80
Misses 1124 1124 ☔ View full report in Codecov by Sentry. |
|
@jkauerl are you still working on that? |
Yes, I implemented most of the suggestions, and do not know what else is missing. |
Pull Request Template
Description
PR including the implementation for the Negative Log Likelihood Loss Function of this issue #559 . It creates a new file called
negative_log_likelihood.rswith the function calledneg_log_likelihood. This implementation is for binary classifications, but can be expanded to higher dimensions.Type of change
Checklist:
cargo clippy --all -- -D warningsjust before my last commit and fixed any issue that was found.cargo fmtjust before my last commit.cargo testjust before my last commit and all tests passed.mod.rsfile within its own folder, and in any parent folder(s).DIRECTORY.mdwith the correct link.COUNTRIBUTING.mdand my code follows its guidelines.