fix: Propagate null values in Wrap* methods #982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivarah
changed the title
zivarah
force-pushed
the
propagate-null-in-wrappers
branch
from
3801795 to
c6c2907
Compare
vbreuss
referenced
this pull request
in Testably/Testably.Abstractions
May 5, 2023
…19.2.22 (#303) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions) | nuget | patch | `19.2.18` -> `19.2.22` | --- ### Release Notes <details> <summary>TestableIO/System.IO.Abstractions</summary> ### [`v19.2.22`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.22) #### What's Changed - chore(deps): update dependency githubactionstestlogger to v2.0.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/978](https://togithub.com/TestableIO/System.IO.Abstractions/pull/978) - chore(deps): update danielpalme/reportgenerator-github-action action to v5.1.20 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/979](https://togithub.com/TestableIO/System.IO.Abstractions/pull/979) - chore(deps): update dependency nerdbank.gitversioning to v3.6.128 by [@​renovate](https://togithub.com/renovate) in [https://github.com/TestableIO/System.IO.Abstractions/pull/980](https://togithub.com/TestableIO/System.IO.Abstractions/pull/980) - fix: Propagate null values in Wrap\* methods by [@​zivarah](https://togithub.com/zivarah) in [https://github.com/TestableIO/System.IO.Abstractions/pull/982](https://togithub.com/TestableIO/System.IO.Abstractions/pull/982) #### New Contributors - [@​zivarah](https://togithub.com/zivarah) made their first contribution in [https://github.com/TestableIO/System.IO.Abstractions/pull/982](https://togithub.com/TestableIO/System.IO.Abstractions/pull/982) **Full Changelog**: TestableIO/System.IO.Abstractions@v19.2.18...v19.2.22 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43MS4wIiwidXBkYXRlZEluVmVyIjoiMzUuNzEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
This is addressed in release v19.2.22. |
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wrapping
FileSystemInfo,DirectoryInfo, andFileInfo, null inputs will be correctly propagated.Prior to this change, the wrappers for all three of these types would throw exceptions:
NullReferenceExceptionforWrapFileSystemInfoArgumentNullExceptionforWrapDirectoryInfo/WrapFileInfo(thrown byDirectoryInfoWrapper/FileInfoWrapper)Basic unit tests were also added for these null cases.
Fixes #981