-
Notifications
You must be signed in to change notification settings - Fork 316
fix(Input): the change event is invalid for skyline and type = 'nickname' #3858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anlyyao
wants to merge
3
commits into
develop
Choose a base branch
from
fix/input/nickname
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +34 B (+0.01%) Total Size: 236 kB
ℹ️ View Unchanged
|
commit: |
betavs
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
fix #3855
💡 需求背景和解决方案
为什么不直接复用 onInput ?
A:原生input 组件的 bindinput 和 bindchange 在内容改变时均会被触发。如果直接复用 onInput,会导致在大部分场景下,onInput 被频繁触发。因此 bindchange 独立出来,且处理 skyline + type = 'nickname' 场景中,bindinput 无效的问题。
📝 更新日志
fix(Input): 修复在
skyline
和type = 'nickname'
场景下,change
事件无效的问题本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单