fix(table-core): use right Document instance on getResizeHandler (column-sizing feature) #5989
+72
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 92b9e1e.
☁️ Nx Cloud last updated this comment at |
riccardoperra
changed the title
KevinVandy
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to my comment #5747 (comment)
I'd consider to remove jsdom env in table-core test since since this package should be framework agnostic. It could ensure us that things doesn't break while running the code in a non browser env. wdyt?
I've added two new utils safelyAccessDocument and safelyAccessDocumentEvent just for testing purposes (actually using only
safelyAccessDocument) as it can be useful to reuse that portion of code also in other files. Those utils are not currently present in public api, is it ok?