-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore(deps): update all non-major dependencies #8963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Command | Status | Duration | Result |
---|---|---|---|
nx affected --targets=test:sherif,test:knip,tes... |
❌ Failed | 1m 13s | View ↗ |
nx run-many --target=build --exclude=examples/*... |
❌ Failed | 9s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-08-30 05:58:05
UTC
f5886b1
to
e17502f
Compare
49a66df
to
69ffb91
Compare
1bf5e5a
to
7bd4eca
Compare
7bd4eca
to
02fef8c
Compare
8fe64ef
to
3242f07
Compare
3242f07
to
ebe29cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 15
🧹 Nitpick comments (30)
examples/vue/nuxt3/package.json (1)
12-14
: Validate Node version compatibility and build output
- Ensure local and CI Node.js versions meet Nuxt 3.18.1’s minimum requirement (>=16.x).
- Run
npx nuxi build
inexamples/vue/nuxt3
and confirm the server entry is at.output/server/index.mjs
.- (Optional) Add an
"engines": { "node": ">=16.14.0" }
field toexamples/vue/nuxt3/package.json
to enforce this in CI.examples/react/default-query-function/package.json (1)
17-20
: LGTM on Vite/plugin-react bumps; ensure Node ≥18 in envs.Vite 6.x requires Node 18+. CI likely already uses this, but double-check local and example app engines to avoid dev friction. If needed, add an engines field to the example.
Example engines snippet (if you choose to set it locally in this package.json):
{ "engines": { "node": ">=18" } }.github/workflows/ci.yml (1)
30-31
: actions/checkout updated — consider pinning to commit SHA for supply-chain hardening.Tag versions are mutable. Pin to the immutable commit for v4.3.0 (and for codecov too) to reduce risk. Optional: split “Test” and “Publish” into separate jobs with least-privilege permissions (read for tests; write only for publish).
.github/workflows/autofix.yml (1)
21-21
: Pin actions/checkout to a commit SHA.Same supply-chain recommendation as ci.yml: replace the tag with the corresponding commit digest.
.github/workflows/pr.yml (2)
25-25
: Consider pinning actions/checkout to a commit SHA for supply-chain hardening.
You already pin marocchino/sticky-pull-request-comment by SHA; doing the same for actions/checkout reduces risk.Also applies to: 54-54
33-33
: Optionally pin nrwl/nx-set-shas by SHA and add job timeouts.
Pinning actions and addingtimeout-minutes:
help avoid stuck runs.Example (no exact SHAs provided here):
- uses: nrwl/nx-set-shas@
- at job level:
timeout-minutes: 30
packages/react-query-persist-client/package.json (1)
69-69
: Consider dropping @vitejs/plugin-react here (unused, adds a peer on vite).This package doesn’t run Vite (no vite script/devDep). Keeping the plugin can cause peer warning noise. Either remove it or add vite as a devDep if there’s an internal need.
Apply to remove if unused:
- "@vitejs/plugin-react": "^4.7.0",
examples/svelte/basic/package.json (1)
17-18
: Enforce minimum Node version in CI workflows
Addactions/setup-node@v3
withnode-version: '18.x'
(or higher) to each workflow in.github/workflows/*.yml
so CI uses a modern Node runtime.Align Devcontainer support
Angular examples already use Node 22 via their devcontainer images; Svelte examples currently lack devcontainer configuration—consider adding or updating a.devcontainer/devcontainer.json
pointing to a Node 18+ image for local consistency.examples/svelte/optimistic-updates/package.json (1)
15-22
: SvelteKit 2.37 + Vite 6 + Svelte 5 update: align engines for examples.These require Node >=18; consider declaring engines to avoid local dev surprises.
Add an engines field:
{ "name": "@tanstack/query-example-svelte-optimistic-updates", "private": true, "type": "module", + "engines": { + "node": ">=18.18.0" + }, "scripts": {packages/query-devtools/package.json (1)
67-81
: Heads-up: 0.x minors can be breaking (solid-transition-group 0.3.0)
Only packages/query-devtools/package.json usessolid-transition-group@^0.3.0
; no mismatches elsewhere. Please smoke-test Devtools UI transitions/animations.Consider adding a minimal interactive visual test (e.g. Storybook or a vitest-dom screenshot) for transition regressions to catch animation API changes early.
examples/react/react-router/package.json (1)
23-24
: Bump @types/react and @types/react-dom to 19.x in react-router example
examples/react/react-router/package.json (lines 23–24) uses React ^19.0.0 but still pins types at 18.x, leading to potential type skew.- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.1", + "@types/react-dom": "^19.0.2",packages/angular-query-persist-client/package.json (1)
73-76
: Peer range sanity check for Angular 21+.Peer deps are ">=16.0.0". If Angular 21 introduces breaking changes, consider capping at <21 until verified.
Optionally tighten:
- "@angular/common": ">=16.0.0", - "@angular/core": ">=16.0.0", + "@angular/common": ">=16.0.0 <21", + "@angular/core": ">=16.0.0 <21",examples/angular/basic/package.json (2)
22-24
: Align Angular CLI/build patch versions for consistency.Not required, but consider bumping @angular/build and @angular/cli from ^20.2.1 to ^20.2.3 to match core.
- "@angular/build": "^20.2.1", - "@angular/cli": "^20.2.1", + "@angular/build": "^20.2.3", + "@angular/cli": "^20.2.3",
19-19
: Consider caret range for zone.js.Pinning to 0.15.1 is fine; if you prefer auto-patching, use ^0.15.1.
examples/angular/query-options-from-a-service/package.json (1)
23-25
: Optional: bump CLI/build to match core.For uniformity with 20.2.3:
- "@angular/build": "^20.2.1", - "@angular/cli": "^20.2.1", - "@angular/compiler-cli": "^20.2.3", + "@angular/build": "^20.2.3", + "@angular/cli": "^20.2.3", + "@angular/compiler-cli": "^20.2.3",examples/angular/optimistic-updates/package.json (1)
12-20
: Ensure consistent Angular and zone.js version pinningAll Angular examples and the angular-cli-20 integration are locked to ^20.2.3 for Angular packages; zone.js is pinned exactly (
0.15.1
) in examples and with a tilde (~0.15.1
) in angular-cli-20. Consider standardizing on^0.15.1
for zone.js across the board to automatically receive patch fixes.examples/angular/basic-persister/package.json (1)
12-21
: Align persist-client version in basic-persister example
In examples/angular/basic-persister/package.json the current@tanstack/angular-query-persist-client
is ^5.62.7 while@tanstack/query-async-storage-persister
(and other TanStack deps) are ^5.85.5—either bump the persist-client to ^5.85.5 for consistency or verify that mixing ^5.62.7 with ^5.85.5 is compatible.examples/react/eslint-legacy/package.json (1)
23-25
: Sync React typings in eslint-legacy exampleeslint-legacy’s package.json depends on React ^19.0.0 but still declares
@types/react
and@types/react-dom
at v18.x, which can cause type-resolution conflicts. Bump both to ^19.0.0 (or remove them to rely on React 19’s built-in types):"devDependencies": { "@tanstack/eslint-plugin-query": "^5.83.1", - "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.0", + "@types/react-dom": "^19.0.0", "@vitejs/plugin-react": "^4.7.0", "typescript": "5.8.3", "vite": "^6.3.5" },examples/angular/simple/package.json (1)
19-19
: Consider unpinning zone.js to receive patch fixes automatically.If reproducibility isn’t a goal for examples, prefer a caret.
- "zone.js": "0.15.1" + "zone.js": "^0.15.1"examples/angular/router/package.json (1)
20-20
: Optional: allow zone.js patches.- "zone.js": "0.15.1" + "zone.js": "^0.15.1"examples/angular/rxjs/package.json (1)
20-20
: Optional: loosen zone.js pin for patches.- "zone.js": "0.15.1" + "zone.js": "^0.15.1"examples/react/star-wars/package.json (1)
11-20
: MUI v6 + @mui/styles: validate continued need for JSS.If the example doesn’t rely on legacy JSS APIs, consider removing @mui/styles and using @emotion (already present) or @mui/system to simplify deps.
examples/angular/infinite-query-with-max-pages/package.json (1)
19-19
: Pin vs. caret for zone.js.You’re pinning zone.js to 0.15.1. Consider ^0.15.1 to receive patch fixes automatically across examples (optional).
examples/angular/auto-refetching/package.json (2)
19-19
: Optional: loosen zone.js to caret.Use ^0.15.1 to pick up patches automatically (optional).
22-24
: Align patch versions for Angular toolchainBump @angular/cli and @angular/build from ^20.2.1 to ^20.2.3 to match @angular/compiler-cli and ensure consistent patch levels.
package.json (1)
41-45
: ESLint/Testing/tooling bumps — watch for rule changes and perfUpgrades to eslint@^9.34, [email protected], and eslint-plugin-react-hooks@^6.0.0-rc1 can surface new lint errors. Run the full “test:ci” locally to validate. If noise increases, consider pinning exact versions for the rc.
Also applies to: 49-55, 56-59, 77-79
packages/angular-query-experimental/package.json (2)
83-85
: Bound Angular peer ranges to tested majorsCurrent peer ranges are open-ended (>=16). To avoid accidental installs with future Angular majors (e.g., 21+) that haven’t been validated, cap at <21.
Apply:
"peerDependencies": { - "@angular/common": ">=16.0.0", - "@angular/core": ">=16.0.0" + "@angular/common": ">=16.0.0 <21", + "@angular/core": ">=16.0.0 <21" },
34-41
: Add TS 5.8 to type-check matrix (examples already use TS 5.8.x)Scripts test up to ts57, while examples pin TS 5.8.x. Add a ts58 lane to keep the matrix aligned.
I can draft the script entry (and root deps) if you want to extend the matrix to typescript58.
examples/angular/pagination/package.json (1)
25-25
: Consider loosening TypeScript pin to allow patch updatesOptional: switch from exact "5.8.3" to "~5.8.3" to receive patch fixes automatically, unless you require full lock for reproducibility.
- "typescript": "5.8.3" + "typescript": "~5.8.3"integrations/angular-cli-20/package.json (1)
12-21
: Angular integration deps look consistent; minor consistency nitsThe non-major bumps across Angular, rxjs, tslib, zone.js, and our experimental package are coherent.
- Zone.js versioning style differs from examples (here: "~0.15.1", examples: "0.15.1"). Consider unifying across the repo for consistency.
- If we formally support Angular >=16 per package peers, consider adding CI jobs to build this integration against a small matrix (e.g., 16, 17, 18, 19, 20) to detect drift early.
Also applies to: 24-26
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml
(1 hunks).github/workflows/ci.yml
(1 hunks).github/workflows/pr.yml
(2 hunks)examples/angular/auto-refetching/package.json
(1 hunks)examples/angular/basic-persister/package.json
(1 hunks)examples/angular/basic/package.json
(1 hunks)examples/angular/devtools-panel/package.json
(1 hunks)examples/angular/infinite-query-with-max-pages/package.json
(1 hunks)examples/angular/optimistic-updates/package.json
(1 hunks)examples/angular/pagination/package.json
(1 hunks)examples/angular/query-options-from-a-service/package.json
(1 hunks)examples/angular/router/package.json
(1 hunks)examples/angular/rxjs/package.json
(1 hunks)examples/angular/simple/package.json
(1 hunks)examples/react/algolia/package.json
(2 hunks)examples/react/basic-graphql-request/package.json
(1 hunks)examples/react/basic/package.json
(1 hunks)examples/react/chat/package.json
(1 hunks)examples/react/default-query-function/package.json
(1 hunks)examples/react/devtools-panel/package.json
(1 hunks)examples/react/eslint-legacy/package.json
(1 hunks)examples/react/offline/package.json
(1 hunks)examples/react/playground/package.json
(1 hunks)examples/react/react-native/package.json
(1 hunks)examples/react/react-router/package.json
(1 hunks)examples/react/rick-morty/package.json
(1 hunks)examples/react/shadow-dom/package.json
(1 hunks)examples/react/simple/package.json
(1 hunks)examples/react/star-wars/package.json
(1 hunks)examples/react/suspense/package.json
(1 hunks)examples/solid/astro/package.json
(1 hunks)examples/solid/basic-graphql-request/package.json
(1 hunks)examples/solid/basic/package.json
(1 hunks)examples/solid/default-query-function/package.json
(1 hunks)examples/solid/simple/package.json
(1 hunks)examples/solid/solid-start-streaming/package.json
(1 hunks)examples/svelte/auto-refetching/package.json
(1 hunks)examples/svelte/basic/package.json
(1 hunks)examples/svelte/load-more-infinite-scroll/package.json
(1 hunks)examples/svelte/optimistic-updates/package.json
(1 hunks)examples/svelte/playground/package.json
(1 hunks)examples/svelte/simple/package.json
(1 hunks)examples/svelte/ssr/package.json
(1 hunks)examples/svelte/star-wars/package.json
(1 hunks)examples/vue/2.6-basic/package.json
(1 hunks)examples/vue/2.7-basic/package.json
(1 hunks)examples/vue/basic/package.json
(1 hunks)examples/vue/dependent-queries/package.json
(1 hunks)examples/vue/nuxt3/package.json
(1 hunks)examples/vue/persister/package.json
(1 hunks)examples/vue/simple/package.json
(1 hunks)integrations/angular-cli-20/package.json
(1 hunks)integrations/react-next-15/package.json
(1 hunks)integrations/react-vite/package.json
(1 hunks)integrations/react-webpack-4/package.json
(1 hunks)integrations/react-webpack-5/package.json
(1 hunks)integrations/solid-vite/package.json
(1 hunks)integrations/svelte-vite/package.json
(1 hunks)integrations/vue-vite/package.json
(1 hunks)package.json
(3 hunks)packages/angular-query-devtools-experimental/package.json
(1 hunks)packages/angular-query-experimental/package.json
(1 hunks)packages/angular-query-persist-client/package.json
(1 hunks)packages/eslint-plugin-query/package.json
(1 hunks)packages/query-async-storage-persister/package.json
(1 hunks)packages/query-broadcast-client-experimental/package.json
(1 hunks)packages/query-core/package.json
(1 hunks)packages/query-devtools/package.json
(1 hunks)packages/query-persist-client-core/package.json
(1 hunks)packages/query-sync-storage-persister/package.json
(1 hunks)packages/query-test-utils/package.json
(1 hunks)packages/react-query-devtools/package.json
(1 hunks)packages/react-query-next-experimental/package.json
(1 hunks)packages/react-query-persist-client/package.json
(1 hunks)packages/react-query/package.json
(1 hunks)packages/solid-query-devtools/package.json
(1 hunks)packages/solid-query-persist-client/package.json
(1 hunks)packages/solid-query/package.json
(1 hunks)packages/svelte-query-devtools/package.json
(1 hunks)packages/svelte-query-persist-client/package.json
(1 hunks)packages/svelte-query/package.json
(1 hunks)packages/vue-query-devtools/package.json
(1 hunks)packages/vue-query/package.json
(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
PR: TanStack/query#9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
Applied to files:
packages/solid-query-devtools/package.json
🔇 Additional comments (79)
packages/query-test-utils/package.json (1)
37-39
: Verify CLI binary availability
Nonpm-run-all
ornpm-run-all2
invocations were detected in any script definitions—confirm thatnpm-run-all2@^5.0.2
still provides thenpm-run-all
binary in your CI and local environments, or update your scripts to callnpm-run-all2
explicitly to prevent potential failures.examples/solid/basic-graphql-request/package.json (1)
13-21
: Verify peer compatibility & Node version
Add an"engines": {"node": ">=18"}
entry to examples/solid/basic-graphql-request/package.json (Vite 6 requires Node ≥18) and confirm that installinggraphql@^16.11.0
withgraphql-request@^7.2.0
yields no peer-dependency warnings.packages/vue-query-devtools/package.json (1)
56-63
: ESLint plugin-vue bump: manual lint verification required
No explicit “vue/…” rules found in your ESLint configs; run full lint (e.g.npm run lint
orpnpm lint
) across all packages to catch any deprecated/renamed rules after upgrading eslint-plugin-vue.integrations/react-next-15/package.json (1)
9-15
: No action needed for Temporal polyfill upgrade
OnlyTemporal.PlainDate.from()
,.toJSON()
andinstanceof Temporal.PlainDate
are used—none of the v0.5.0 breaking changes (calendar/timeZone API swaps, etc.) affect these methods.examples/react/devtools-panel/package.json (1)
17-20
: Confirm no peer-dependency warnings after bump
examples/react/devtools-panel/package.json declares no peerDependencies—runnpm install
(orpnpm install
) locally to verify there are no peer-dependency warnings with Vite 6.3.5 + @vitejs/plugin-react 4.7.0.examples/react/shadow-dom/package.json (1)
19-22
: Good: versions consistent with React 19 types and Vite 6.No issues spotted.
integrations/svelte-vite/package.json (1)
12-13
: Peer dependencies and examples consistency verified
@ sveltejs/[email protected] declares"svelte": "^5.0.0"
and"vite": "^6.0.0"
, which covers the bumped^5.38.6
and^6.3.5
, and all examples/integrations uniformly use those versions. No further changes needed.examples/solid/basic/package.json (1)
13-19
: Solid/Vite bumps look consistent.solid-js 1.9.9 + vite 6.3.5 + vite-plugin-solid 2.11.8 align. Same Node ≥18 note applies if examples are run standalone.
examples/solid/solid-start-streaming/package.json (1)
14-19
: Aligned Solid Start + vinxi versions; engines already specify Node ≥18.Looks good. Keep an eye on peer dep warnings between @solidjs/start and vinxi during install.
packages/query-persist-client-core/package.json (1)
66-66
: Patch bump to npm-run-all2 looks safeNo behavior change expected; scripts remain compatible.
examples/vue/dependent-queries/package.json (1)
15-18
: Confirm Node version compatibility and Vue 3 tooling alignment
All Vue 3 examples (simple
,persister
,basic
,dependent-queries
) consistently use"@vitejs/plugin-vue": "^5.2.4"
and"vite": "^6.3.5"
, while Vue 2 examples remain on Vite ^4.5.14 as expected. There’s currently no"engines"
field in thesepackage.json
files—please ensure your CI/dev environments run a Node.js version compatible with Vite 6.3.x (Node >=14.18 or ≥16), or consider adding an"engines"
entry to enforce this.examples/svelte/load-more-infinite-scroll/package.json (1)
15-22
: Verify example dev build & typecheck
Runnpm run dev
andnpm run check
inexamples/svelte/load-more-infinite-scroll
to ensure there are no runtime or type errors.examples/react/basic-graphql-request/package.json (1)
13-20
: graphql-request imports valid for v7 Verified ESM imports ofgql
andrequest
fromgraphql-request
remain supported in v7; no changes required.packages/angular-query-devtools-experimental/package.json (1)
57-62
: Looks good—verified all Angular example and integration packages are pinned to ^20.2.3 for @angular/common, @angular/core, and @angular/platform-browser.integrations/solid-vite/package.json (1)
11-13
: Dependencies are consistent for Solid + Vite across all packages. No version drift detected.examples/vue/simple/package.json (1)
16-19
: No stale Vue plugin or Vite versions detected. All Vue 3 packages use@vitejs/plugin-vue@^5.2.4
andvite@^6.3.5
, and Vue 2 examples correctly usevite@^4.5.14
.examples/vue/basic/package.json (1)
16-19
: Consistent with the Vue simple example; OK to merge.
No concerns. Same minor/patch levels as elsewhere in the PR.examples/react/algolia/package.json (2)
11-11
: Algolia client minor bump is safe for this example.
Already on v5 previously; staying within major. Keeping it pinned (exact) matches how examples are typically curated.
21-24
: Peer-dependency check passed – all Vite‐based React examples uniformly use @vitejs/plugin-react ^4.7.0 with vite ^6.3.5, and non-Vite examples correctly omit both. No peer-warning issues remain.packages/react-query-persist-client/package.json (2)
67-67
: @testing-library/react bump looks compatible with React 19.No action needed; peer alignment with react ^19 and @types/react ^19.0.1 looks good.
70-70
: npm-run-all2 patch bump is fine.Safe maintenance update.
packages/query-async-storage-persister/package.json (1)
66-66
: npm-run-all2 patch bump OK.No runtime impact; safe maintenance.
examples/solid/default-query-function/package.json (2)
13-13
: solid-js ^1.9.9 bump looks fine.No API changes expected for examples.
17-19
: Vite and vite-plugin-solid bumps look good; ensure CI shows no peer dependency warnings or build failures with Vite 6. (classic.yarnpkg.com)packages/svelte-query/package.json (1)
50-56
: Peer dependency compatibility confirmed—no action needed. @sveltejs/[email protected] declares vite^6.0.0
and svelte^5.0.0
, and [email protected] requires Node >=18.examples/react/offline/package.json (1)
16-25
: Engine & peer versions compatible—confirm ESM setup
Node v24.3.0 meets msw’s>=18
, TypeScript 5.8.3 meets msw’s>=4.8.x
, and Vite 6.3.5 satisfies @vitejs/plugin-react’s peer^4.2.0 || ^5.0.0 || ^6.0.0 || ^7.0.0
. Verify your example’spackage.json
uses"type": "module"
(or equivalent ESM config) so MSW can load correctly.integrations/react-vite/package.json (1)
11-15
: Peer dependencies align correctly
Confirmed that @vitejs/[email protected] declaresvite: '^4.2.0 || ^5.0.0 || ^6.0.0 || ^7.0.0'
, satisfying Vite ^6.x. No changes required.examples/solid/simple/package.json (1)
13-20
: Peer dependencies are satisfied
solid-js ^1.9.9 satisfies [email protected]’s peer solid-js ^1.7.2, and vite ^6.3.5 falls within its peer vite ^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0.integrations/vue-vite/package.json (1)
13-16
: Drop bump suggestion: [email protected] supports Vite 6
plugin-vue@^5.2.4 declares vite:^5.0.0||^6.0.0 in its peerDependencies, so it’s fully compatible with Vite 6; upgrading to v6.x is optional.Likely an incorrect or invalid review comment.
integrations/react-webpack-5/package.json (1)
14-16
: Confirmed Babel loader presets are correctly referenced
Thebabel-loader
rule inintegrations/react-webpack-5/webpack.config.js
uses['@babel/preset-env', '@babel/preset-react']
, matching the bumped versions—no further changes needed.packages/solid-query-devtools/package.json (1)
68-71
: Solid devDeps bumps look fine and match the rest of the Solid packages.Peer range already allows 1.x, so no peer change needed.
packages/solid-query-persist-client/package.json (1)
73-76
: Aligned Solid tooling versions across packages. LGTM.packages/svelte-query-persist-client/package.json (1)
50-50
: Build and types not verifiable without installing dependencies
The compile step failed (tsc
not found), indicating node_modules aren’t installed. Please install dependencies (e.g.,pnpm install
) and re-run the package’scompile
andtest:types
scripts to confirm the Svelte toolchain bump introduces no regressions.examples/svelte/simple/package.json (1)
16-21
: Vite/Svelte bumps LGTM; ensure Node version in CI covers Vite 6.Upgrading to Vite 6.3.5 and Svelte 5.38.6 is fine for this example. Double-check CI Node matrix includes a supported version for Vite 6 (generally Node 18+), and that @sveltejs/vite-plugin-svelte 5.1.1 remains compatible.
packages/svelte-query-devtools/package.json (1)
45-45
: esm-env and Svelte toolchain bumps: no API impact; proceed.esm-env to ^1.2.2 and Svelte-related devDeps to latest patch are safe. Please run the package’s build to ensure no environment-conditional code relies on older esm-env behavior.
Also applies to: 48-48, 52-53
examples/vue/2.6-basic/package.json (1)
18-18
: Vite 4 patch bump compatible with vue2 plugin.vite ^4.5.14 matches vite-plugin-vue2 2.0.3; no breaking changes expected. Keep this example pinned to Vite 4 as intended.
examples/svelte/auto-refetching/package.json (1)
15-16
: SvelteKit/adapter and Vite patch bumps: OK; smoke-test SSR.SvelteKit ^2.37.0 + adapter-auto ^6.1.0 with Vite 6.3.5 should be fine. Run a quick dev/build/preview to confirm SSR example still renders and client hydration is clean.
Also applies to: 18-19, 21-21
packages/query-core/package.json (1)
63-63
: Drop Node engine compatibility check for [email protected]. npm-run-all2 v5.0.2 declaresNode>=4
, so it runs on all supported Node versions—no CI or engines field updates needed. (npmjs.com)Likely an incorrect or invalid review comment.
examples/vue/2.7-basic/package.json (1)
17-17
: Vite 4.5.14 bump looks safe for Vue 2.7 + vite-plugin-vue2.No breaking changes expected; ensure lockfile is updated and local Node >= 14.18 (repo likely on >=18).
packages/vue-query/package.json (2)
66-66
: Patch bump for @vue/devtools-api is fine.No runtime surface change expected here.
73-73
: CI must pass post-upgrade
eslint-plugin-vue is consistently set to ^9.33.0 in both packages (no mixed versions); adjust config if new lint rules or warnings appear.integrations/react-webpack-4/package.json (1)
14-17
: Confirm webpack-cli v4 build flags are correct
The existing build script already useswebpack --mode production
(the required flag model in CLI v4 with webpack 4). Runnpm run build
inintegrations/react-webpack-4
to ensure it still succeeds.packages/query-broadcast-client-experimental/package.json (1)
62-62
: broadcast-channel update verified: no subpath imports or leader-election APIs are used in this package, so upgrading to ^7.1.0 is safe.packages/query-sync-storage-persister/package.json (1)
67-67
: npm-run-all2 patch bump is safeLooks good; no action needed.
examples/react/react-router/package.json (2)
17-19
: Router bump LGTM; no API changes expected.6.25.1 -> 6.30.1 is a safe minor/patch upgrade for this example.
26-26
: Vite/tooling bumps look good.@vitejs/plugin-react ^4.7.0 and vite ^6.3.5 are compatible and match other examples.
Also applies to: 28-28
packages/angular-query-persist-client/package.json (1)
60-65
: Angular devDeps upgrade LGTM.Upgrading to Angular 20.2.3 and test/tooling patches is consistent with the repo-wide sweep.
Also applies to: 67-71
packages/react-query-devtools/package.json (2)
86-86
: @testing-library/react bump LGTM.v16.3.0 works with React 18/19 and shouldn’t require source changes.
88-89
: Tooling bumps LGTM.@vitejs/plugin-react ^4.7.0 and npm-run-all2 ^5.0.2 are fine; no build script changes needed.
examples/angular/basic/package.json (1)
12-15
: Angular core + zone.js updates LGTM.20.2.3 and zone.js 0.15.1 are compatible with this example’s setup.
Also applies to: 19-19
examples/angular/query-options-from-a-service/package.json (1)
12-16
: Angular framework + router + zone.js updates LGTM.Version set is consistent with other Angular examples.
Also applies to: 20-20
examples/svelte/ssr/package.json (1)
15-22
: All Svelte examples are aligned: every Vite ^6 package uses @sveltejs/vite-plugin-svelte ^5.1.1 and @sveltejs/kit ^2.37.0 where applicable (the “simple” example omits SvelteKit by design).examples/angular/optimistic-updates/package.json (1)
23-26
: Ensure CI Node versions align with Angular 20 requirements. CI workflows don’t reference anyactions/setup-node
ornode-version
settings—please confirm your CI matrix explicitly covers the Node LTS ranges required by Angular 20 (e.g. Node 18.x and Node 20.x).packages/react-query-next-experimental/package.json (1)
61-64
: Versions consistent across the workspaceNo mismatched versions found for “@vitejs/plugin-react”, “vite”, or “npm-run-all2”—all packages use the intended bumps.
examples/angular/basic-persister/package.json (1)
24-26
: Tooling alignment: @angular/ dev tools are consistent.*Looks good at 20.2.x. Ensure local dev uses a matching global CLI to avoid version negotiation prompts.
examples/angular/simple/package.json (2)
12-15
: LGTM on aligned Angular minor versions.All Angular packages are on 20.2.x and in sync.
Also applies to: 22-24
12-15
: Confirm TypeScript peer dependency covers 5.8.3.
Only @angular/[email protected] declares"typescript": ">=5.8 <6.0"
, which includes 5.8.3; the other Angular packages don’t list TypeScript as a peer dependency—no install-time warnings expected.examples/angular/router/package.json (2)
12-16
: Versions aligned across @angular/ (good).*
12-16
: TS 5.8.3 is compatible with Angular 20.2.x peer dependencies. @angular/[email protected] and @angular/[email protected] declaretypescript
>=5.8 <6.0; the runtime packages have no TS peerDependency.examples/angular/rxjs/package.json (2)
12-16
: Angular packages are consistently on 20.2.3.
12-16
: Confirmed: Angular 20.2.3 supports TS 5.8.3 (peerDependencies.typescript >=5.8 <6.0 in @angular/compiler-cli).examples/svelte/star-wars/package.json (1)
15-25
: LGTM on Svelte and tooling bumps.Versions are coherent with Svelte 5 and vite-plugin-svelte ^5.
examples/react/star-wars/package.json (1)
11-21
: Deps are coherent (emotion + MUI + React Router).No API-surface changes implied here.
examples/angular/infinite-query-with-max-pages/package.json (2)
12-15
: Angular 20.2.x bumps look good.Nothing risky here for the example; TS 5.8.3 aligns with Angular 20.2.x.
22-24
: No update needed: @angular/cli and @angular/build v20.2.3 aren’t released. Leave both at ^20.2.1 and align to 20.2.3 once those patch versions become available.packages/solid-query/package.json (2)
74-78
: Dev tool bumps LGTM.npm-run-all2, solid-js, and vite-plugin-solid minor bumps are safe for local dev/build.
79-81
: PeerDependency range remains accurate
Only thebatch
API from solid-js is used in this package, and it has been available since v1.5.0; locking peers to^1.6.0
covers this and later releases. (docs.solidjs.com, github.com)examples/angular/auto-refetching/package.json (1)
12-15
: Angular 20.2.x bumps LGTM.Matches the broader repo upgrade pattern; compatible with TS 5.8.3.
packages/eslint-plugin-query/package.json (1)
62-70
: ESLint 9 + @typescript-eslint v8 alignment looks correct.utils/parser/rule-tester are all 8.41.0; eslint is ^9.34.0. Peer range already allows ^9.
examples/react/rick-morty/package.json (2)
19-20
: React Router API unchanged—6.30.1 bump is safe No removed or renamed exports in this example.
11-14
: UI stack bumps LGTM; watch legacy @mui/styles with React 19. Verified onlymakeStyles
imports in Layout.tsx and Home.jsx; no inconsistent styled-engine usage detected.examples/vue/persister/package.json (1)
15-15
: LGTM — minor bumps look safeVite/plugin-vue/idb-keyval minor/patch updates are compatible and low-risk for this example. Consider confirming Node version in CI (Vite 6 expects modern Node) but otherwise good.
Also applies to: 19-19, 21-21
examples/solid/astro/package.json (1)
15-15
: Astro/Solid/Tailwind minor bumps — verify peer compatibilityLooks fine overall. Please run a quick build to confirm no peer warnings between astro@^5, @astrojs/*, solid-js@^1.9.9, and tailwindcss@^3.4.17.
Also applies to: 17-17, 21-22, 22-22
examples/angular/devtools-panel/package.json (1)
12-16
: Angular 20.2.x + zone.js 0.15.1 alignment looks correctDependencies and devDependencies are in the expected ranges for Angular 20.2.x; tslib is already ^2.8.1. No issues spotted.
Also applies to: 21-21, 24-26
package.json (1)
8-8
: pnpm bump — ensure CI runners matchpackageManager is now [email protected]. Verify CI images and local dev use this version to avoid lockfile/install diffs.
packages/angular-query-experimental/package.json (2)
71-74
: Angular devDependency bumps look goodNon-major upgrades to Angular 20.2.x and tooling are consistent with the repo-wide renovate sweep. No source/API impact here.
Also applies to: 76-78
45-47
: Verifytest:build
passes post vite-plugin-dts upgrade
test:build
failed locally (nx: not found
, missingnode_modules
). Install dependencies (pnpm install
) and rerunpnpm -w -r --filter @tanstack/angular-query-experimental run test:buildto confirm d.ts bundling remains clean.
examples/angular/pagination/package.json (1)
12-15
: TypeScript peer dependency range satisfies 5.8.3; approving updates.integrations/angular-cli-20/package.json (1)
27-27
: No changes needed: TypeScript "~5.8.2" satisfies the compiler-cli peer requirement (>=5.8 <6.0)
"@vitejs/plugin-react": "^4.7.0", | ||
"typescript": "5.8.3", | ||
"vite": "^6.2.4" | ||
"vite": "^6.3.5" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Align React type packages with React 19 (or drop them if not needed).
This example depends on react/react-dom ^19 but still uses @types/react@^18 and @types/react-dom@^18 in devDependencies, which can cause TS friction. Bump to ^19 or remove if React 19 ships types sufficient for your setup.
Suggested devDependencies snippet (outside the changed lines):
{
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0"
}
🏁 Script executed:
#!/bin/bash
# Report react 19 examples that still pin @types/react or @types/react-dom to 18.x
rg -nP --glob 'examples/react/**/package.json' '"react":\s*"\^19[^"]*"' | cut -d: -f1 | sort -u | while read -r f; do
mis=""
rg -q '"@types/react":\s*"\^18' "$f" && mis+=" @types/react^18"
rg -q '"@types/react-dom":\s*"\^18' "$f" && mis+=" @types/react-dom^18"
[[ -n "$mis" ]] && echo "Mismatch: $f ->$mis"
done
Length of output: 4358
Align @types/react and @types/react-dom to ^19 in React example packages
The following examples depend on react/react-dom ^19 but still pin their type packages at ^18, which can cause TypeScript conflicts. Update or remove these devDependencies:
• examples/react/algolia/package.json
• examples/react/basic/package.json
• examples/react/eslint-legacy/package.json
• examples/react/react-router/package.json
Suggested devDependencies update:
"devDependencies": {
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0"
}
🤖 Prompt for AI Agents
In examples/react/basic/package.json around lines 23 to 26, the package pins
TypeScript type packages to React 18 while the example depends on
react/react-dom ^19; update the devDependencies to align by replacing or
updating "@types/react" and "@types/react-dom" to "^19.0.0" (or remove them if
you intentionally rely on the React 19 built-in types), ensuring TypeScript type
versions match the runtime React version to avoid type conflicts.
"@tailwindcss/vite": "^4.1.12", | ||
"@vitejs/plugin-react": "^4.7.0", | ||
"tailwindcss": "^4.1.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
React + Vite + Tailwind bumps look consistent; verify example parity across React folders.
These versions should work together (React 19 + @vitejs/plugin-react 4.x + Vite 6.3 + Tailwind 4.1). Suggest checking all React examples use the same Vite/plugin versions to avoid CI drift.
Run to spot any React example still on older Vite/plugin-react:
Also applies to: 21-21
🏁 Script executed:
#!/bin/bash
fd package.json examples/react -t f \
| xargs -I{} bash -lc 'printf "%s -> " "{}"; jq -r '"'"'.devDependencies["vite"], .devDependencies["@vitejs/plugin-react"]'"'"' "{}" | paste -sd " / " -' \
| rg -nPv '\^6\.3\.5\s+/\s+\^4\.7\.0' -v
Length of output: 5013
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
echo "Checking Vite and @vitejs/plugin-react versions across React examples..."
fd package.json examples/react -t f | while IFS= read -r file; do
vite=$(jq -r '.devDependencies["vite"] // ""' "$file")
plugin=$(jq -r '.devDependencies["@vitejs/plugin-react"] // ""' "$file")
if [[ "$vite" != "^6.3.5" ]] || [[ "$plugin" != "^4.7.0" ]]; then
echo "$file -> vite: $vite, plugin-react: $plugin"
fi
done
Length of output: 9274
Add missing vite
^6.3.5 and @vitejs/plugin-react
^4.7.0 to all React example devDependencies
The following examples lack these entries in their package.json
:
- examples/react/auto-refetching/package.json
- examples/react/infinite-query-with-max-pages/package.json
- examples/react/load-more-infinite-scroll/package.json
- examples/react/nextjs/package.json
- examples/react/nextjs-app-prefetching/package.json
- examples/react/nextjs-suspense-streaming/package.json
- examples/react/optimistic-updates-cache/package.json
- examples/react/optimistic-updates-ui/package.json
- examples/react/pagination/package.json
- examples/react/prefetching/package.json
- examples/react/react-native/package.json
🤖 Prompt for AI Agents
In examples/react/chat/package.json around lines 17 to 19, devDependencies are
missing the required "vite": "^6.3.5" and "@vitejs/plugin-react": "^4.7.0"; add
those two entries under devDependencies in this file and the same two entries
into each of the listed React example package.json files
(examples/react/auto-refetching, examples/react/infinite-query-with-max-pages,
examples/react/load-more-infinite-scroll, examples/react/nextjs,
examples/react/nextjs-app-prefetching, examples/react/nextjs-suspense-streaming,
examples/react/optimistic-updates-cache, examples/react/optimistic-updates-ui,
examples/react/pagination, examples/react/prefetching,
examples/react/react-native) ensuring they are valid JSON keys in
devDependencies and preserve trailing commas/formatting consistent with each
file.
"@vitejs/plugin-react": "^4.7.0", | ||
"typescript": "5.8.3", | ||
"vite": "^6.2.4" | ||
"vite": "^6.3.5" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
React example tooling bumps look good; same Node >= 18 check as above.
No additional concerns.
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Quick smoke: list Vite versions declared in examples
fd -a package.json examples -t f -E node_modules | xargs -I{} jq -r '.name + " vite=" + (.devDependencies.vite // "MISSING") + " :: " + input_filename' {} | rg -n "MISSING|^"
Length of output: 7324
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
# Verify Node engine requirement in react/playground example
file=$(fd -g 'package.json' examples/react/playground)
echo "Checking: $file"
rg -nP '"engines"\s*:\s*\{' -nC2 "$file" || echo "no engines block"
rg -nP '"node"\s*:\s*".*>=\s*18.*"' -nC1 "$file" || echo "no node >=18 requirement"
Length of output: 1324
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
file=$(fd -g 'package.json' examples/react/playground)
echo "File: $file"
sed -n '1,200p' "$file"
Length of output: 738
Add Node >=18 engine constraint to react/playground example
examples/react/playground/package.json is missing the engines
field; add the same Node >=18 check as in other examples. For example:
"engines": {
"node": ">=18"
},
🤖 Prompt for AI Agents
In examples/react/playground/package.json around lines 17 to 20, the
package.json is missing an "engines" field; add an "engines" object with "node":
">=18" (matching other examples) to enforce Node >=18 for this example project,
placing it at the top-level of package.json (e.g., alongside name/version) and
ensure valid JSON formatting and trailing commas are adjusted accordingly.
"expo": "^52.0.47", | ||
"expo-constants": "^17.1.7", | ||
"expo-status-bar": "^2.2.3", | ||
"react": "^19.0.0", | ||
"react-native": "^0.76.3", | ||
"react-native-gesture-handler": "^2.20.2", | ||
"react-native-paper": "^5.12.5", | ||
"react-native-reanimated": "^3.16.2", | ||
"react-native-safe-area-context": "^4.12.0", | ||
"react-native-screens": "^4.1.0", | ||
"react-native-web": "^0.19.13" | ||
"react-native": "^0.81.1", | ||
"react-native-gesture-handler": "^2.28.0", | ||
"react-native-paper": "^5.14.5", | ||
"react-native-reanimated": "^3.19.1", | ||
"react-native-safe-area-context": "^4.14.1", | ||
"react-native-screens": "^4.15.4", | ||
"react-native-web": "^0.21.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
❓ Verification inconclusive
Potential Expo/RN incompatibility: Expo SDK 52 vs react-native ^0.81.1
Expo SDKs pin a specific react-native version. Upgrading RN to ^0.81.1 may be incompatible with expo ^52.0.47 and can break native builds/Dev Client. Recommend aligning RN to the version Expo 52 supports (or upgrading Expo to an SDK that supports RN 0.81), via “expo install” to resolve the correct versions.
Apply this safe revert unless you plan to bump Expo SDK accordingly:
- "react-native": "^0.81.1",
+ "react-native": "^0.76.3",
Then run: npx expo install to ensure all Expo-managed deps (reanimated, gesture-handler, screens, safe-area-context, react-native-web) match the SDK matrix.
Also applies to: 32-33
Align React Native version to Expo SDK 52
Expo SDK 52 targets React Native 0.76.x. In examples/react/react-native/package.json
, update:
- "react-native": "^0.81.1",
+ "react-native": "0.76.0",
Then run npx expo install
to sync all Expo-managed dependencies. If you need React Native 0.81.x, upgrade Expo to SDK 53 or later. (docs.expo.dev)
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"expo": "^52.0.47", | |
"expo-constants": "^17.1.7", | |
"expo-status-bar": "^2.2.3", | |
"react": "^19.0.0", | |
"react-native": "^0.76.3", | |
"react-native-gesture-handler": "^2.20.2", | |
"react-native-paper": "^5.12.5", | |
"react-native-reanimated": "^3.16.2", | |
"react-native-safe-area-context": "^4.12.0", | |
"react-native-screens": "^4.1.0", | |
"react-native-web": "^0.19.13" | |
"react-native": "^0.81.1", | |
"react-native-gesture-handler": "^2.28.0", | |
"react-native-paper": "^5.14.5", | |
"react-native-reanimated": "^3.19.1", | |
"react-native-safe-area-context": "^4.14.1", | |
"react-native-screens": "^4.15.4", | |
"react-native-web": "^0.21.1" | |
"expo": "^52.0.47", | |
"expo-constants": "^17.1.7", | |
"expo-status-bar": "^2.2.3", | |
"react": "^19.0.0", | |
"react-native": "0.76.0", | |
"react-native-gesture-handler": "^2.28.0", | |
"react-native-paper": "^5.14.5", | |
"react-native-reanimated": "^3.19.1", | |
"react-native-safe-area-context": "^4.14.1", | |
"react-native-screens": "^4.15.4", | |
"react-native-web": "^0.21.1" |
🤖 Prompt for AI Agents
In examples/react/react-native/package.json around lines 19 to 29, the React
Native version (^0.81.1) is incompatible with Expo SDK 52 which targets React
Native 0.76.x; update the react-native entry to a 0.76.x compatible version
(e.g., 0.76.x), then run npx expo install to resync all Expo-managed
dependencies; alternatively, if you need RN 0.81.x, upgrade Expo to SDK 53+ and
then run npx expo install to align versions.
"rooks": "^8.0.0", | ||
"react-router": "^6.30.1", | ||
"react-router-dom": "^6.30.1", | ||
"rooks": "^8.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Confirm rooks compatibility with React 19.
Rooks generally supports modern React, but please verify no peer warning after install.
Run:
🏁 Script executed:
#!/bin/bash
pnpm -w -F @tanstack/query-example-react-router install --frozen-lockfile && pnpm -w -F @tanstack/query-example-react-router build
Length of output: 4332
Fix unresolved @tanstack/react-query entry and confirm rooks compatibility.
Build is failing with “Failed to resolve entry for package "@tanstack/react-query"”. Adjust the module’s exports or Vite configuration so the example builds successfully, then re-run install/build and verify no peer warnings for rooks@^8.4.0
.
"@sveltejs/adapter-auto": "^6.1.0", | ||
"@sveltejs/kit": "^2.37.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
SvelteKit 2.37 + Vite 6.3: ensure Node engine in CI matches requirements.
Minor bumps look fine. Please confirm CI/engines are Node ≥18 (Kit/Vite requirement).
Also applies to: 20-25
🌐 Web query:
What Node.js version is required for SvelteKit 2.37 and Vite 6.3?
💡 Result:
- SvelteKit 2.37: requires Node.js 18.13 or newer. [1]
- Vite 6.3: Vite 6 supports Node.js 18, 20 and 22+ (minimum Node 18). [2]
Sources:
[1] SvelteKit migration/docs (Updated dependency requirements).
[2] Vite 6 announcement / docs (Node.js support).
Require Node.js ≥18.13.0 in CI and package.json engines
Update examples/svelte/star-wars/package.json
engines to "node": ">=18.13.0"
and ensure CI runs on Node.js v18.13.0 or newer (SvelteKit 2.37 requires v18.13+; Vite 6.3 supports v18+).
🤖 Prompt for AI Agents
In examples/svelte/star-wars/package.json around lines 15-16, update the engines
field to require Node.js ≥18.13.0 by adding or changing "node": ">=18.13.0"
under "engines"; also ensure the repository CI workflow(s) that run this example
are configured to use Node 18.13.0 or newer (update the CI job matrix or
node-version entry to >=18.13.0) so the example and CI match SvelteKit/Vite
minimum Node requirements.
"eslint": "^9.34.0", | ||
"npm-run-all2": "^5.0.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Ensure Node engine compatibility for ESLint 9.
ESLint 9 requires Node ≥18.18. Verify the repo’s engines field (root) enforces this.
🏁 Script executed:
#!/bin/bash
jq -r '.engines? // {}' package.json
Length of output: 41
Add Node engine requirement to root package.json
Root package.json currently has no engines
field but ESLint 9 (and its @eslint packages) require Node ≥ 18.18.0 (e.g. @eslint/eslintrc: node: '^18.18.0 || ^20.9.0 || >=21.1.0'
). Add to the root package.json
:
"engines": {
"node": ">=18.18.0"
}
🤖 Prompt for AI Agents
In packages/eslint-plugin-query/package.json around lines 68 to 69, the root
package.json is missing an engines field and ESLint v9 requires Node >=18.18.0;
add an "engines" object to the root package.json with "node": ">=18.18.0" (e.g.,
add "engines": { "node": ">=18.18.0" }) so package consumers and CI enforce the
minimum Node version required by ESLint and related packages.
"@testing-library/react": "^16.3.0", | ||
"@vitejs/plugin-react": "^4.7.0", | ||
"npm-run-all2": "^5.0.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
@vitejs/plugin-react 4.7.0: ensure Vite 6.x alignment across the repo
Plugin 4.x expects Vite 6. Verify all packages/examples using this plugin also declare Vite ^6 to avoid peer warnings/miscompiles.
🏁 Script executed:
#!/bin/bash
# Print plugin-react and vite versions per package.json
fd -a package.json | while read -r f; do
plugin=$(jq -r '.devDependencies["@vitejs/plugin-react"] // empty' "$f")
vite=$(jq -r '.devDependencies.vite // empty' "$f")
if [[ -n "$plugin" ]]; then
echo "$f -> plugin-react=$plugin | vite=$vite"
fi
done
# Flag any with plugin-react present but no vite 6.x
fd -a package.json | xargs -I{} jq -r '[
input_filename,
.devDependencies["@vitejs/plugin-react"] // empty,
.devDependencies.vite // empty
] | @tsv' {} | awk -F'\t' 'NF==3 && $2!="" && $3!~/^(\^|~)?6\./ {print "CHECK: " $1 " plugin-react=" $2 " vite=" $3}'
Length of output: 29603
Add vite
^6.x devDependency to packages/query-broadcast-client-experimental
@vitejs/plugin-react@^4.7.0
requires Vite 6.x; add
"vite": "^6.x"
under devDependencies
in packages/query-broadcast-client-experimental/package.json.
🤖 Prompt for AI Agents
In packages/query-broadcast-client-experimental/package.json around lines 65 to
67, the package lists @vitejs/plugin-react@^4.7.0 which requires Vite 6.x but
Vite is missing from devDependencies; add "vite": "^6.x" to the devDependencies
section of that package.json so the plugin's peer dependency is satisfied and
installs the correct Vite major version.
"@tanstack/query-test-utils": "workspace:*", | ||
"@tanstack/react-query": "workspace:*", | ||
"@testing-library/react": "^16.1.0", | ||
"@testing-library/react": "^16.3.0", | ||
"@types/react": "^19.0.1", | ||
"@vitejs/plugin-react": "^4.3.4", | ||
"npm-run-all2": "^5.0.0", | ||
"@vitejs/plugin-react": "^4.7.0", | ||
"npm-run-all2": "^5.0.2", | ||
"react": "^19.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Repo-wide check: ensure all vite plugins have local vite devDep or rely on root intentionally.
Quick sanity script to flag packages that declare a Vite plugin without a local vite devDep:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
fd -a package.json -t f -E node_modules | while read -r f; do
jq -r '
.name as $n
| (if (.devDependencies?["@vitejs/plugin-react"] and (.devDependencies.vite|not)) then "MISSING vite (react plugin) -> \($n) :: " + input_filename else empty end),
(if (.devDependencies?["vite-plugin-solid"] and (.devDependencies.vite|not)) then "MISSING vite (solid plugin) -> \($n) :: " + input_filename else empty end)
' "$f"
done | sed '/^$/d'
Length of output: 41273
Add missing vite
devDependency to packages using Vite plugins
The following packages declare @vitejs/plugin-react
or vite-plugin-solid
without a local vite
devDependency—add "vite": "<appropriate-version>"
to each or confirm they intentionally rely on the root devDependency.
- packages/query-broadcast-client-experimental (uses
@vitejs/plugin-react
) - packages/query-devtools (uses
vite-plugin-solid
) - packages/react-query (uses
@vitejs/plugin-react
) - packages/react-query-devtools (uses
@vitejs/plugin-react
) - packages/react-query-next-experimental (uses
@vitejs/plugin-react
) - packages/react-query-persist-client (uses
@vitejs/plugin-react
) - packages/solid-query (uses
vite-plugin-solid
) - packages/solid-query-devtools (uses
vite-plugin-solid
) - packages/solid-query-persist-client (uses
vite-plugin-solid
)
🤖 Prompt for AI Agents
In packages/react-query-persist-client/package.json around lines 65 to 71, the
package lists @vitejs/plugin-react but does not declare a local vite
devDependency; add a vite devDependency with the appropriate version (matching
monorepo/root or the plugin's compatible version) to devDependencies in this
package.json, or explicitly document/confirm in the package.json that it
intentionally relies on the root workspace devDependency; ensure the version
string matches other packages using Vite to avoid mismatches.
"@testing-library/react": "^16.3.0", | ||
"@testing-library/react-render-stream": "^2.0.1", | ||
"@types/react": "^19.0.1", | ||
"@types/react-dom": "^19.0.2", | ||
"@vitejs/plugin-react": "^4.3.4", | ||
"npm-run-all2": "^5.0.0", | ||
"@vitejs/plugin-react": "^4.7.0", | ||
"npm-run-all2": "^5.0.2", | ||
"react": "^19.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Testing libs/tooling bumps LGTM; check React 19 + RTL 16 matrix in CI
Versions align with React 19. Ensure CI runs the test suite for React 18 and 19 to catch regressions in @testing-library/react and the render-stream helper.
🏁 Script executed:
#!/bin/bash
# Quick sanity: list RTL versions and react versions in all packages to spot divergence
fd -a package.json | while read -r f; do
rtl=$(jq -r '.devDependencies["@testing-library/react"] // empty' "$f")
react=$(jq -r '.devDependencies.react // .peerDependencies.react // empty' "$f")
if [[ -n "$rtl" || -n "$react" ]]; then
echo "$f -> rtl=$rtl react=$react"
fi
done
Length of output: 29783
🏁 Script executed:
#!/bin/bash
# Find CI workflow
echo "Workflows:"
fd -t f -g ".github/workflows/*.yml"
for file in $(fd -t f -g ".github/workflows/*.yml"); do
echo "=== $file ==="
grep -R "matrix" -n "$file"
done
Length of output: 523
🏁 Script executed:
#!/bin/bash
# Locate CI configuration files
echo "GitHub Actions workflows:"
find . -type f -path "./.github/workflows/*.yml"
echo "CircleCI config:"
find . -type f -path "./.circleci/*.yml"
echo "Travis config:"
find . -maxdepth 1 -type f -name ".travis.yml"
Length of output: 401
🏁 Script executed:
#!/bin/bash
# Check test matrix for React versions
grep -R "matrix" -n -C3 .github/workflows/ci.yml
Length of output: 48
🏁 Script executed:
#!/bin/bash
# Dump first 200 lines of CI workflow to inspect test matrix
sed -n '1,200p' .github/workflows/ci.yml
Length of output: 1664
🏁 Script executed:
#!/bin/bash
# Show the test:ci script definition in root package.json
echo "test:ci script:"
jq -r '.scripts["test:ci"]' package.json
Length of output: 176
Add React 18 & 19 matrix in CI
Extend .github/workflows/ci.yml
’s test-and-publish
job to include a matrix for react-version: [18.x, 19.x]
so @testing-library/react v16.3.0 is validated against both React 18 and 19.
This PR contains the following updates:
5.2.1
->5.36.0
^20.0.0
->^20.2.3
^20.0.0
->^20.2.1
^20.0.0
->^20.2.1
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^20.0.0
->^20.2.3
^0.15.3
->^0.18.2
^5.0.7
->^5.1.0
^8.1.3
->^8.2.7
^7.26.0
->^7.28.3
^7.24.9
->^7.28.3
^7.26.0
->^7.28.3
^7.25.9
->^7.27.1
^8.17.1
->^8.19.4
^11.13.5
->^11.14.0
^11.13.5
->^11.14.1
^1.52.3
->^1.52.8
^10.0.5
->^10.0.11
^0.4.4
->^0.5.1
^0.13.4
->^0.13.11
^6.1.8
->^6.5.0
^6.1.8
->^6.4.8
^1.2.2
->^1.5.2
^2.0.26
->^2.1.3
^1.1.3
->^1.1.7
^6.0.1
->^6.1.0
^2.25.1
->^2.37.0
^2.4.0
->^2.5.0
^4.0.14
->^4.1.12
^5.76.0
->^5.85.5
^0.19.0
->^0.20.1
^17.3.7
->^17.4.0
^10.4.0
->^10.4.1
^6.6.3
->^6.8.0
^16.1.0
->^16.3.0
^2.0.0
->^2.0.1
^5.0.4
->^5.0.5
^8.37.0
->^8.41.0
^8.37.0
->^8.41.0
^8.37.0
->^8.41.0
^4.3.4
->^4.7.0
^4.3.4
->^4.7.0
^5.2.1
->^5.2.4
3.1.3
->3.2.4
^1.1.36
->^1.3.4
^6.6.3
->^6.6.4
v4.2.2
->v4.3.0
^8.3.0
->^8.4.1
^7.0.0
->^7.1.0
^9.15.0
->^9.34.0
^50.5.0
->^50.8.0
^6.0.0-rc.1
->^6.0.0-rc1
^9.27.0
->^9.33.0
^1.2.1
->^1.2.2
^52.0.11
->^52.0.47
^17.0.3
->^17.1.7
^2.0.0
->^2.2.3
^16.9.0
->^16.11.0
^7.1.2
->^7.2.0
^5.6.3
->^5.6.4
^6.2.1
->^6.2.2
^5.50.2
->^5.63.0
^2.6.6
->^2.10.5
^5.0.0
->^5.0.2
v4.1.2
->v4.3.3
^3.12.4
->^3.18.1
21.3.0
->21.4.1
10.13.1
->10.15.0
^2.5.2
->^2.6.0
^0.76.3
->^0.81.1
^2.20.2
->^2.28.0
^5.12.5
->^5.14.5
^3.16.2
->^3.19.1
^4.12.0
->^4.14.1
^4.1.0
->^4.15.4
^0.19.13
->^0.21.1
^6.25.1
->^6.30.1
^6.25.1
->^6.30.1
^8.0.0
->^8.4.0
~7.8.0
->~7.8.2
^1.9.7
->^1.9.9
^1.9.7
->^1.9.9
^0.2.3
->^0.3.0
^5.36.8
->^5.38.6
^4.3.0
->^4.3.1
^3.4.7
->^3.4.17
^3.4.7
->^3.4.17
^4.0.14
->^4.1.12
^2.3.0
->^2.8.1
^0.5.3
->^0.5.8
^6.2.4
->^6.3.5
^6.2.4
->^6.3.5
^4.5.3
->^4.5.14
4.2.3
->4.5.4
^2.11.6
->^2.11.8
^2.11.6
->^2.11.8
Summary by CodeRabbit