Skip to content

Conversation

harry-whorlow
Copy link
Contributor

@harry-whorlow harry-whorlow commented Aug 2, 2025

Add's form identifiers to form in preparation for dev-tools

Copy link

nx-cloud bot commented Aug 2, 2025

View your CI Pipeline Execution ↗ for commit 49bac16

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 21s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 20s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-05 13:41:16 UTC

Copy link

pkg-pr-new bot commented Aug 2, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1659

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1659

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1659

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1659

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1659

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1659

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1659

commit: 49bac16

Copy link

codecov bot commented Aug 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.50%. Comparing base (c82fe54) to head (49bac16).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1659      +/-   ##
==========================================
+ Coverage   90.49%   90.50%   +0.01%     
==========================================
  Files          37       37              
  Lines        1683     1685       +2     
  Branches      421      421              
==========================================
+ Hits         1523     1525       +2     
  Misses        143      143              
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harry-whorlow
Copy link
Contributor Author

Im thinking about adding fieldId too, that you an pass to form props (which will add generated path to the form's fieldId) and field props (overrides form fieldId). But I'm not certain on this yet.

@harry-whorlow
Copy link
Contributor Author

I'm not sure it's useful to store the ID in the store, I figured someone might want to access it through the useStore... not entirely convinced though

@LeCarbonator
Copy link
Contributor

@harry-whorlow The only way to change the formId is to pass a different value to the useForm hook, at which point the id might as well be passed by whatever's changing anyways.

I don't mind it being in store or it being basic state, it's up to you.

@harry-whorlow
Copy link
Contributor Author

@LeCarbonator yeah, I was thinking about this last night... seems like extra code for no real benefit, and at least for now is probably not going to be used very often at least till dev tools are added.

I'm unconvinced we even need to include it in the docs, or at least the current implementation of the docs. I'm struggling to see where this would be appropriate to put since it's pretty intuitive.

@harry-whorlow harry-whorlow marked this pull request as ready for review August 4, 2025 17:05
Copy link
Contributor

@LeCarbonator LeCarbonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harry-whorlow harry-whorlow merged commit 2c9bab0 into TanStack:main Aug 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants