-
-
Notifications
You must be signed in to change notification settings - Fork 512
feat(core): form identifiers #1659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
View your CI Pipeline Execution ↗ for commit 49bac16
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1659 +/- ##
==========================================
+ Coverage 90.49% 90.50% +0.01%
==========================================
Files 37 37
Lines 1683 1685 +2
Branches 421 421
==========================================
+ Hits 1523 1525 +2
Misses 143 143
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Im thinking about adding fieldId too, that you an pass to form props (which will add generated path to the form's fieldId) and field props (overrides form fieldId). But I'm not certain on this yet. |
I'm not sure it's useful to store the ID in the store, I figured someone might want to access it through the useStore... not entirely convinced though |
@harry-whorlow The only way to change the I don't mind it being in store or it being basic state, it's up to you. |
@LeCarbonator yeah, I was thinking about this last night... seems like extra code for no real benefit, and at least for now is probably not going to be used very often at least till dev tools are added. I'm unconvinced we even need to include it in the docs, or at least the current implementation of the docs. I'm struggling to see where this would be appropriate to put since it's pretty intuitive. |
73b6447
to
8b5af03
Compare
8b5af03
to
46857fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add's form identifiers to form in preparation for dev-tools