Skip to content

Initializes text upon object creation. #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Initializes text upon object creation. #597

wants to merge 3 commits into from

Conversation

@FearDragon
Copy link
Contributor

LeeTwentyThree
LeeTwentyThree requested changes Mar 13, 2025
View reviewed changes
Copy link
Member

@LeeTwentyThree LeeTwentyThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will probably need another solution since InitializeText isn't made properly to fit in the constructor.

Nautilus/Utility/BasicText.cs Outdated
{
X = set_x;
Y = set_y;
InitializeText();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are unneeded since the base constructor calls InitializeText

Nautilus/Utility/BasicText.cs Outdated
{
X = set_x;
Y = set_y;
InitializeText();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InitializeText();

Nautilus/Utility/BasicText.cs Outdated
{
CloneAlign = false;
Align = useAlign;
InitializeText();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InitializeText();

Nautilus/Utility/BasicText.cs Outdated
{
CloneColor = false;
Color = useColor;
InitializeText();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InitializeText();

Nautilus/Utility/BasicText.cs Outdated
{
CloneSize = false;
Size = useSize;
InitializeText();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InitializeText();

Nautilus/Utility/BasicText.cs Outdated
Color = useColor;
CloneSize = false;
Size = useSize;
InitializeText();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InitializeText();

Nautilus/Utility/BasicText.cs Outdated
Color = useColor;
CloneSize = false;
Size = useSize;
InitializeText();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InitializeText();

Nautilus/Utility/BasicText.cs Outdated
Color = useColor;
CloneSize = false;
Size = useSize;
InitializeText();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InitializeText();

Nautilus/Utility/BasicText.cs Outdated
Y = set_y;
CloneSize = false;
Size = useSize;
InitializeText();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InitializeText();

@LeeTwentyThree
Copy link
Member

LeeTwentyThree commented Mar 25, 2025 •
edited
Loading

I see the problems with this now. It is getting close, but the CloneColor property (which seems pointless) is overriding the color value. I would just make CloneColor obsolete, remove references to it, and set the Color to white by default.

@LeeTwentyThree
Copy link
Member

LeeTwentyThree commented Mar 25, 2025 •
edited
Loading

Also, since InitializeText is being called as soon as the constructor is called, there's a chance that it's being created in the main menu in mods, which means it is destroyed when it reaches the main game scene. That needs to be addressed somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeeTwentyThree LeeTwentyThree LeeTwentyThree requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Nautilus 1.0.0.34] BasicText.SetColor does not work until after .ShowMessage is called

2 participants

@FearDragon @LeeTwentyThree