A new sorter : Lupin sorter #4192
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…erface into memory_template_similarity
for more information, see https://pre-commit.ci
…erface into memory_template_similarity
for more information, see https://pre-commit.ci
…ikeinterface into lupin_sorter
|
@alejoe91 @chrishalcrow |
for more information, see https://pre-commit.ci
| mode="memory", | ||
| memory_limit=0.5, | ||
| total_memory=None, | ||
| delete_cache=True, |
There was a problem hiding this comment.
You don't use delete_cache anywhere
There was a problem hiding this comment.
You still don't use delete_cache anywhere - get rid of it!
| # sparsity_snr = compute_sparsity(templates_dense, method="snr", amplitude_mode="peak_to_peak", | ||
| # noise_levels=noise_levels, threshold=sparsity_threshold) | ||
| # sparsity.mask = sparsity.mask & sparsity_snr.mask | ||
| # templates = templates_dense.to_sparse(sparsity) |
There was a problem hiding this comment.
Go through and delete not-needed comments, please
| # sparsity_mask=None, | ||
| # probe=recording_for_peeler.get_probe(), | ||
| # is_in_uV=False, | ||
| # ) |
There was a problem hiding this comment.
loads of commented out stuff in this file
| }, | ||
| "merge_from_features": None, | ||
| # "merge_from_features": {}, | ||
| # "merge_from_features": {"merge_radius_um": 60.0}, |
There was a problem hiding this comment.
I get nervous with these commented out parameters - you definitely want to use "merge_from_features": None,, right?
There was a problem hiding this comment.
I need to keep then commented to remember the option we could test
3 participants
Gentleman thief spike sorter.
This sorter is composed by pieces of code and ideas stolen everywhere : yass, tridesclous, spkyking-circus, kilosort.
It should be the best sorter we can build using spikeinterface.sortingcomponents
This depend on #4182