fix openapi json schema integrity #102
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a missing closing brace around the
market/supplyendpoint, making the JSON invalid. That also led to a duplicateparameterskey/value.Can check the formatting of the original w/
jq . reference/SpaceTraders.jsonThere was a seemingly unused
application/xmldefinition as well for that endpoint. For the generators, 3.1.1 seems to want to have a license identifier (although that should be optional so far as I know) so I added it.The openapi-generator-cli w/ ts client doesnt like 3.1.1 btw, so to get a client generated for myself I downgraded the schema to
3.0.3But this PR just fixes the schema integrity for what was merged in, with the additional changes of adding the
identifierand removing the application/xml object.