Skip to content

SLVS-2557 Fix: Roslyn documents are not reanalyzed on cross-file changes #6470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Parent: SLVS-1940 [Visual Studio] Integrate Roslyn languages analysis with SLCore
wants to merge 2 commits into
base: feature/sqvs-roslyn-plugin-rebased-3
Choose a base branch
from
Draft

SLVS-2557 Fix: Roslyn documents are not reanalyzed on cross-file changes #6470

wants to merge 2 commits into from

Conversation

@georgii-borovinskikh-sonarsource
Copy link
Contributor

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource commented Oct 24, 2025 •
edited by atlassian bot
Loading

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource changed the base branch from master to feature/sqvs-roslyn-plugin-rebased-3 October 24, 2025 14:15
@sonarqubecloud
Copy link

SonarQube reviewer guide

Summary: Refactors analysis queue system by removing DocumentUpdated events and simplifying issue consumer storage

Review Focus:

  • The new IAnalysisQueue interface and implementation that centralizes document tracking
  • Removal of analysisId parameter from IIssueConsumerStorage interface methods
  • Changes to DocumentEventArgs constructor removing content parameter
  • Removal of GetAnalysisLanguageFromExtension method from SonarLanguageRecognizer

Start review at: src/Integration.Vsix/SonarLintTagger/IAnalysisQueue.cs. This is the core new abstraction that replaces the distributed analysis tracking logic and centralizes document state management.

💬 Please send your feedback

Quality Gate Failed Quality Gate failed

Failed conditions
9 New issues
38.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@georgii-borovinskikh-sonarsource