Skip to content

SLVS-2541 Migrate SQVS repo from Cirrus CI to Github actions #6460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

SLVS-2541 Migrate SQVS repo from Cirrus CI to Github actions #6460

wants to merge 3 commits into from

Conversation

@vnaskos-sonar
Copy link
Contributor

@vnaskos-sonar vnaskos-sonar commented Oct 6, 2025 •
edited by atlassian bot
Loading

@vnaskos-sonar vnaskos-sonar marked this pull request as draft October 6, 2025 13:23
@vnaskos-sonar vnaskos-sonar force-pushed the vn/migrate-to-github-actions branch 20 times, most recently from a9846b4 to a46825a Compare October 10, 2025 13:33
@vnaskos-sonar vnaskos-sonar force-pushed the vn/migrate-to-github-actions branch 6 times, most recently from ca13625 to de9d3f0 Compare October 16, 2025 09:12
@sonarqube-cloud-us
Copy link

sonarqube-cloud-us bot commented Oct 16, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 Dependency risks

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube Cloud

@sonarqube-next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@vnaskos-sonar vnaskos-sonar force-pushed the vn/migrate-to-github-actions branch from 2695ab3 to 44c3d7d Compare October 16, 2025 14:00
@vnaskos-sonar vnaskos-sonar force-pushed the vn/migrate-to-github-actions branch 9 times, most recently from 14e1370 to 69f79d3 Compare October 17, 2025 16:25
@vnaskos-sonar vnaskos-sonar marked this pull request as ready for review October 20, 2025 07:02
@vnaskos-sonar vnaskos-sonar force-pushed the vn/migrate-to-github-actions branch from 69f79d3 to 95b5fc3 Compare October 20, 2025 09:23
eray-felek-sonarsource
eray-felek-sonarsource reviewed Oct 22, 2025
View reviewed changes
eray-felek-sonarsource
eray-felek-sonarsource reviewed Oct 22, 2025
View reviewed changes
Copy link
Contributor

@eray-felek-sonarsource eray-felek-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to remove required build run from cirrus

eray-felek-sonarsource
eray-felek-sonarsource requested changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@eray-felek-sonarsource eray-felek-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slack notification is missing

hedinasr
hedinasr reviewed Oct 27, 2025
View reviewed changes
hedinasr
hedinasr reviewed Oct 27, 2025
View reviewed changes
hedinasr
hedinasr approved these changes Oct 27, 2025
View reviewed changes
Copy link

@hedinasr hedinasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnaskos-sonar vnaskos-sonar force-pushed the vn/migrate-to-github-actions branch from dd0d55b to f9285c9 Compare October 27, 2025 12:38
@hedinasr
Copy link

@vnaskos-sonar you probably need to remove the Cirrus build from the GitHub required checks to be able to merge this.

@vnaskos-sonar vnaskos-sonar force-pushed the vn/migrate-to-github-actions branch from 226cfbc to 9b2e0c8 Compare October 27, 2025 14:41
@vnaskos-sonar vnaskos-sonar force-pushed the vn/migrate-to-github-actions branch from 9b2e0c8 to ca0fced Compare October 27, 2025 15:19
@sonarqubecloud
Copy link

SonarQube reviewer guide

Summary: Migrates CI/CD from Cirrus CI to GitHub Actions, removing Cirrus configuration files and adding GitHub workflow files.

Review Focus: Pay attention to the environment variable mappings, secret handling between Vault systems, and the conditional logic for signing artifacts. Verify that all build steps, especially the signing process and platform-specific configurations, are correctly translated.

Start review at: .github/workflows/build.yml. This is the main workflow that replaces the complex Cirrus CI configuration and contains the critical build, test, and deployment logic that needs careful verification.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 Dependency risks

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hedinasr hedinasr hedinasr approved these changes

@eray-felek-sonarsource eray-felek-sonarsource eray-felek-sonarsource approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vnaskos-sonar @hedinasr @eray-felek-sonarsource