Skip to content

Conversation

@gabriela-trutan-sonarsource
Copy link
Contributor

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource commented Aug 21, 2025

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource changed the base branch from feature/sqvs-roslyn-plugin to gt/embed-plugin August 21, 2025 15:06
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource changed the title SLVS-2417 Remove LanguagesWithDisabledAnalysis and make sure raised roslyn issues are no longer filtered out SLVS-2417 Make sure raised roslyn issues are no longer filtered out Aug 21, 2025
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource marked this pull request as ready for review August 21, 2025 15:08
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource marked this pull request as draft August 21, 2025 15:09
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource marked this pull request as ready for review August 22, 2025 06:22
Base automatically changed from gt/embed-plugin to feature/sqvs-roslyn-plugin August 22, 2025 07:51
@gabriela-trutan-sonarsource
Copy link
Contributor Author

@georgii-borovinskikh-sonarsource, I requested review again, because I discovered that the plugin was not used in connected mode, so I needed to do a few more adaptions (besides the renaming).

@sonarqubecloud
Copy link

🤖 Pull Request summary

Updates plugin architecture for C# and VB.NET languages to use new Roslyn-based approach.

Changes:

  • Language.cs: Switches C#/VB.NET from enterprise plugins to sqvsroslyn plugin as primary, with enterprise plugins moved to AdditionalPlugins array (disabled for analysis)
  • PluginInfo.cs: Adds IsEnabledForAnalysis property with default true value to control plugin analysis behavior
  • SLCoreEmbeddedPluginProvider: Renamed from SLCoreEmbeddedPluginJarLocator, now includes Roslyn plugins and provides disabled plugin keys list
  • RaisedFindingProcessor: Removes language filtering logic, now processes all findings regardless of language support

Review Focus:

  • Verify the plugin transition doesn't break existing C#/VB.NET analysis functionality
  • Check that the IsEnabledForAnalysis=false setting for enterprise plugins works as expected
  • Confirm all test updates properly reflect the architectural changes

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants