Skip to content

Attempt to get the correct PR commit hash #10900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2025
Merged

Attempt to get the correct PR commit hash #10900

merged 3 commits into from
Oct 11, 2025

Conversation

Noisyfox
Copy link
Collaborator

@Noisyfox Noisyfox commented Sep 29, 2025 •
edited
Loading

According to https://github.com/orgs/community/discussions/26325
Github PR actions will generate a merge commit before running the build, which means the git commit hash in the PR build will be incorrect and useless.

This PR solves this issue:

image

@Noisyfox Noisyfox added the QoL label Sep 29, 2025
@Noisyfox Noisyfox marked this pull request as ready for review September 29, 2025 06:15
SoftFever
SoftFever approved these changes Oct 11, 2025
View reviewed changes
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you

@SoftFever SoftFever merged commit abe3cd4 into SoftFever:main Oct 11, 2025
12 checks passed
@Noisyfox Noisyfox deleted the dev/pr-sha branch October 11, 2025 13:43
dbaarda pushed a commit to dbaarda/OrcaSlicer that referenced this pull request Oct 12, 2025
Merge branch 'main' into opt-marchsq
199dd7e 
* main:
  Attempt to get the correct PR commit hash (SoftFever#10900)
  Bump tj-actions/changed-files from 46 to 47 (SoftFever#10922)
  Bump actions/setup-python from 5 to 6 (SoftFever#10921)
  Bump actions/github-script from 7 to 8 (SoftFever#10920)
  Bump actions/stale from 9 to 10 (SoftFever#10919)
  [Profiles] Fix bed_exclude_area excluding the whole bed on Anycubic Kobra 3 (SoftFever#10914)
  update de for 2.3.1 after update locale (SoftFever#10912)
dbaarda pushed a commit to dbaarda/OrcaSlicer that referenced this pull request Oct 12, 2025
Merge branch 'opt-marchsq' into opt-dists
4aa62ce 
* opt-marchsq:
  Attempt to get the correct PR commit hash (SoftFever#10900)
  Bump tj-actions/changed-files from 46 to 47 (SoftFever#10922)
  Bump actions/setup-python from 5 to 6 (SoftFever#10921)
  Bump actions/github-script from 7 to 8 (SoftFever#10920)
  Bump actions/stale from 9 to 10 (SoftFever#10919)
  [Profiles] Fix bed_exclude_area excluding the whole bed on Anycubic Kobra 3 (SoftFever#10914)
  update de for 2.3.1 after update locale (SoftFever#10912)
dbaarda pushed a commit to dbaarda/OrcaSlicer that referenced this pull request Oct 12, 2025
Merge branch 'opt-marchsq' into opt-filltpmsfk
ab34842 
* opt-marchsq:
  Attempt to get the correct PR commit hash (SoftFever#10900)
  Bump tj-actions/changed-files from 46 to 47 (SoftFever#10922)
  Bump actions/setup-python from 5 to 6 (SoftFever#10921)
  Bump actions/github-script from 7 to 8 (SoftFever#10920)
  Bump actions/stale from 9 to 10 (SoftFever#10919)
  [Profiles] Fix bed_exclude_area excluding the whole bed on Anycubic Kobra 3 (SoftFever#10914)
  update de for 2.3.1 after update locale (SoftFever#10912)
discip added a commit to discip/OrcaSlicer that referenced this pull request Oct 13, 2025
@discip @dependabot
@Noisyfox @Azio-Pantheon @SoftFever @dazemc @tort32
test update (#47)
ed31bcb 
* Bump actions/stale from 9 to 10 (SoftFever#10919)

Bumps [actions/stale](https://github.com/actions/stale) from 9 to 10.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v9...v10)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-version: '10'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/github-script from 7 to 8 (SoftFever#10920)

Bumps [actions/github-script](https://github.com/actions/github-script) from 7 to 8.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@v7...v8)

---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-version: '8'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/setup-python from 5 to 6 (SoftFever#10921)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5 to 6.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v5...v6)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump tj-actions/changed-files from 46 to 47 (SoftFever#10922)

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 46 to 47.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v46...v47)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-version: '47'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Attempt to get the correct PR commit hash (SoftFever#10900)

* Attempt to get the correct PR commit hash

* Add commit hash to flatpak

* Use given hash if `git_commit_hash` env variable is present

* bugfix for Invalid speed "G1 F-2147483648" (SoftFever#10944)

added non zero safety check for feedrate calculation

* Clarify warning about malicious websites

* overflow inital setup screen (SoftFever#11007)

allow overflow on setup

Co-authored-by: Noisyfox <[email protected]>

* [Profiles] Fix Prusa XL overhang speed (SoftFever#10931) (SoftFever#10933)

Fix reverse order of overhangs slowdown settings

* Delete .github/workflows/assign.yml

* Delete .github/workflows/orca_bot.yml

* Update build_all.yml

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Noisyfox <[email protected]>
Co-authored-by: Azi <[email protected]>
Co-authored-by: SoftFever <[email protected]>
Co-authored-by: Daazed McFarland <[email protected]>
Co-authored-by: Aleksandra M <[email protected]>
discip added a commit to discip/OrcaSlicer that referenced this pull request Oct 13, 2025
@discip @dependabot
@Noisyfox @Azio-Pantheon @SoftFever @dazemc @tort32 @RF47
stringing test rename (#48)
485081a 
* Bump actions/stale from 9 to 10 (SoftFever#10919)

Bumps [actions/stale](https://github.com/actions/stale) from 9 to 10.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v9...v10)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-version: '10'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/github-script from 7 to 8 (SoftFever#10920)

Bumps [actions/github-script](https://github.com/actions/github-script) from 7 to 8.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@v7...v8)

---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-version: '8'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/setup-python from 5 to 6 (SoftFever#10921)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5 to 6.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v5...v6)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump tj-actions/changed-files from 46 to 47 (SoftFever#10922)

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 46 to 47.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v46...v47)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-version: '47'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Attempt to get the correct PR commit hash (SoftFever#10900)

* Attempt to get the correct PR commit hash

* Add commit hash to flatpak

* Use given hash if `git_commit_hash` env variable is present

* bugfix for Invalid speed "G1 F-2147483648" (SoftFever#10944)

added non zero safety check for feedrate calculation

* Clarify warning about malicious websites

* overflow inital setup screen (SoftFever#11007)

allow overflow on setup

Co-authored-by: Noisyfox <[email protected]>

* [Profiles] Fix Prusa XL overhang speed (SoftFever#10931) (SoftFever#10933)

Fix reverse order of overhangs slowdown settings

* Delete .github/workflows/assign.yml

* Delete .github/workflows/orca_bot.yml

* Update build_all.yml

* BUG-FIX avoid crossing perimeters ingonore holes <=2mm (SoftFever#10942)

Fix avoid crossing perimeters 2

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Noisyfox <[email protected]>
Co-authored-by: Azi <[email protected]>
Co-authored-by: SoftFever <[email protected]>
Co-authored-by: Daazed McFarland <[email protected]>
Co-authored-by: Aleksandra M <[email protected]>
Co-authored-by: Rodrigo Faselli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SoftFever SoftFever SoftFever approved these changes

Assignees

No one assigned

Labels

QoL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Noisyfox @SoftFever