Skip to content

Fix cast throwing if existing variable for command storage exists #5942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2023
Merged

Fix cast throwing if existing variable for command storage exists #5942

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70b34c7
Fix cast throwing if existing variable for command storage exists
TheLimeGlass Aug 27, 2023
173935c
Update src/main/java/ch/njol/skript/command/ScriptCommand.java
TheLimeGlass Aug 27, 2023
235b97a
Merge branch 'dev/feature' into fix/command-cooldown-storage
Moderocky Sep 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/main/java/ch/njol/skript/command/ScriptCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,13 @@ public Date getLastUsage(UUID uuid, Event event) {
} else {
String name = getStorageVariableName(event);
assert name != null;
return (Date) Variables.getVariable(name, null, false);
Object variable = Variables.getVariable(name, null, false);
if (!(variable instanceof Date)) {
Skript.warning("Variable {" + name + "} was not a date! You may be using this variable elsewhere. " +
"This warning is letting you know that this variable is now overridden for the command storage.");
return null;
}
return (Date) variable;
}
}

Expand Down