Nits - Metadata

[iamcarbon]

Prerequisites

• I have written a descriptive pull-request title
• I have verified that there are no overlapping pull-requests open
• I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
• I have provided test coverage for my change (where applicable)

Description

A longstanding nit. Metadata is one word and should not be space separated or camelCased.

See:

https://github.com/dotnet/corefx/tree/master/src/System.Reflection.Metadata
dotnet/coreclr@95d37e0
https://en.wikipedia.org/wiki/Metadata

[codecov]

Codecov Report

Merging #879 into master will not change coverage.
The diff coverage is 94.24%.

@@           Coverage Diff           @@
##           master     #879   +/-   ##
=======================================
  Coverage   88.98%   88.98%           
=======================================
  Files        1017     1017           
  Lines       44464    44464           
  Branches     3228     3228           
=======================================
  Hits        39566    39566           
  Misses       4176     4176           
  Partials      722      722

Impacted Files	Coverage Δ
...mageSharp.Tests/TestDataIcc/IccTestDataProfiles.cs	100% <ø> (ø)	⬆️
...files/ICC/DataReader/IccDataReader.TagDataEntry.cs	85.91% <ø> (ø)	⬆️
...les/ICC/TagDataEntries/IccSignatureTagDataEntry.cs	50% <ø> (ø)	⬆️
...MetaData/Profiles/ICC/Various/IccPositionNumber.cs	66.66% <ø> (ø)	⬆️
...Data/Profiles/ICC/DataReader/IccDataReaderTests.cs	100% <ø> (ø)	⬆️
.../ICC/DataReader/IccDataReader.TagDataEntryTests.cs	100% <ø> (ø)	⬆️
...ImageSharp/MetaData/Profiles/ICC/Various/IccLut.cs	87.5% <ø> (ø)	⬆️
...files/ICC/DataWriter/IccDataWriter.TagDataEntry.cs	77.14% <ø> (ø)	⬆️
...ofiles/ICC/DataWriter/IccDataWriter.CurvesTests.cs	100% <ø> (ø)	⬆️
...Data/Profiles/ICC/Curves/IccSampledCurveElement.cs	80% <ø> (ø)	⬆️
... and 168 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dfa2f9...0f8452c. Read the comment docs.

[antonfirsov]

I actually wanted to raise this. Thanks for dealing with it!

[JimBobSquarePants]

Just merged this then realised we've not fixed the actual casing in folders/filenames. I'd like to change the default git config ignorecase property some time and fix everything properly as well as normalize casing for test files (lowecase everything).