-
-
Notifications
You must be signed in to change notification settings - Fork 888
Nits #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Nits #870
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
87a697a
Format conversion models
iamcarbon 0936b58
Format color spaces
iamcarbon 7464682
Add missing periods
iamcarbon 78f9ca5
Replace Endianness enum with isBigEndian
iamcarbon 44b6d31
Seal DoubleBufferedStreamReader
iamcarbon bdb22cb
Remove unused namespaces
iamcarbon 3ed923b
Simplify variable names
iamcarbon c1bceb5
Remove unused namespace
iamcarbon f15d8ec
Format Block8x8F
iamcarbon 0c33d28
Use MathF
iamcarbon 27adde1
Simplify exception when an encoder is not found
iamcarbon 0b6da37
Format ICC models
iamcarbon d22f2a6
Simplify excption messages in ExifValue (reduces IL size)
iamcarbon 8617d93
Merge branch 'master' into cq2
antonfirsov 5a318b6
Add missing periods to documentation.
iamcarbon bebab50
Merge branch 'cq2' of https://github.com/carbon/ImageSharp into cq2
iamcarbon 50ddf07
Format ImageProperty
iamcarbon 29b2ba7
Format BmpImageFormatDetector
iamcarbon f188681
Seal LocalFileSystem
iamcarbon 97048c8
Seal JpegColorConverter implementations
iamcarbon 1164ea3
Add missing periods to jpeg documentation
iamcarbon 9c7e73a
Format ValueSize
iamcarbon 4dce799
Fix stylecop violation
iamcarbon 3f78fe9
Revert "Simplify excption messages in ExifValue (reduces IL size)"
iamcarbon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Public fields should preceed private fields, right? I always get confused by these rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep (and why I reordered this one).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised StyleCop hadn't already picked up on this one.