Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Replaces enum.Equals(object) with enum == enum. Fixes #862

@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc1 milestone Mar 26, 2019
@JimBobSquarePants JimBobSquarePants changed the title Remove Enum comparison Boxing Remove Enum Comparison Boxing Mar 26, 2019
@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #863 into master will decrease coverage by 0.1%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
- Coverage   88.89%   88.79%   -0.11%     
==========================================
  Files        1014     1014              
  Lines       44295    44295              
  Branches     3209     3209              
==========================================
- Hits        39376    39331      -45     
- Misses       4198     4203       +5     
- Partials      721      761      +40
Impacted Files Coverage Δ
src/ImageSharp/Formats/Gif/GifEncoderCore.cs 93.2% <100%> (ø) ⬆️
src/ImageSharp/Formats/Png/PngEncoderCore.cs 93.24% <60%> (-0.28%) ⬇️
...xelFormats/PixelOperations{TPixel}.PixelBenders.cs 89.34% <0%> (-9.84%) ⬇️
...Processing/Processors/Transforms/TransformUtils.cs 88.29% <0%> (-5.32%) ⬇️
src/ImageSharp/Common/Helpers/ImageMaths.cs 82.05% <0%> (-5.13%) ⬇️
.../Processing/Processors/Transforms/CropProcessor.cs 96% <0%> (-4%) ⬇️
...ocessing/Processors/Dithering/ErrorDiffuserBase.cs 93.75% <0%> (-3.13%) ⬇️
...rs/Normalization/HistogramEqualizationProcessor.cs 97.5% <0%> (-2.5%) ⬇️
...ormats/Jpeg/Components/Decoder/QualityEvaluator.cs 94.04% <0%> (-2.39%) ⬇️
...eSharp.Tests/IO/DoubleBufferedStreamReaderTests.cs 97.61% <0%> (-2.39%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eb0122...0f63163. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants