- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 888
Jpeg Fuzz Fixes #836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jpeg Fuzz Fixes #836
Conversation
| There's a fair amount of work here so if anyone fancies chipping in please do. | 
| Codecov Report
 @@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
+ Coverage   88.84%   88.84%   +<.01%     
==========================================
  Files        1015     1015              
  Lines       44167    44185      +18     
  Branches     3180     3185       +5     
==========================================
+ Hits        39241    39258      +17     
- Misses       4201     4203       +2     
+ Partials      725      724       -1
 Continue to review full report at Codecov. 
 | 
| Codecov Report
 @@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
+ Coverage   88.84%   88.87%   +0.02%     
==========================================
  Files        1015     1015              
  Lines       44167    44240      +73     
  Branches     3180     3202      +22     
==========================================
+ Hits        39241    39319      +78     
+ Misses       4201     4200       -1     
+ Partials      725      721       -4
 Continue to review full report at Codecov. 
 | 
| Looks good so far! | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good to me 👍 well done
* Nomalize jpeg exceptions. Fix SixLabors#821 * Fix SixLabors#822 * Fix SixLabors#823 * Check for correct QT index. Touch SixLabors#824 * Check DHT props. Touch SixLabors#824 * Limit sampling factors to 1 & 2. Touch SixLabors#824 * Add already fixed image 4. Touch SixLabors#824 * Check for excessive code lengths. Touch SixLabors#824 * Add already fixed image 6. Touch SixLabors#824 * Lint progressive scan details. Touch SixLabors#824 * Add already fixed image 8. Fix SixLabors#824 * Remove duplicate per-block checks * Add already fixed image 1. Touch SixLabors#825 * Don't throw on bad JFIF density units. * Add already fixed image 3. Touch SixLabors#825 * Add already fixed image 4. Fix SixLabors#825 * Check SOFn marker length. Touch SixLabors#826 * Add already fixed image 2. Touch SixLabors#826 * Add already fixed image 3. Fix SixLabors#826 * Add fixed already fixed image. Fix SixLabors#827 * Revert unneeded bounds check introduced in SixLabors#804
Prerequisites
Description
A combined PR to fix all the recently submitted jpeg fuzz issues.