Skip to content

Gif decoder. Fix memory access violations. #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 21, 2022
Merged

Gif decoder. Fix memory access violations. #2014

merged 6 commits into from
Feb 21, 2022

Conversation

@JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Feb 18, 2022 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fix #2012

  • Fixes GifXmpApplicationExtension by using a more robust (handles empty profiles) and less allocation heavy reader.
  • Provides protection against invalid memory operations in LzwDecoder
  • Fixes cloning of XmpProfile when cloning ImageMetadata

Integrity of reencoded metadata has been tested externally using ExifTools

@JimBobSquarePants JimBobSquarePants added this to the 2.*.* milestone Feb 18, 2022
@JimBobSquarePants JimBobSquarePants requested a review from a team February 18, 2022 15:43
@JimBobSquarePants JimBobSquarePants changed the title Gif decoder. Handle empty XMP profiles. Gif decoder. Fix memory access violations. Feb 19, 2022
This was referenced Feb 19, 2022
Closed
Merged
@JimBobSquarePants JimBobSquarePants requested a review from a team February 21, 2022 07:41
brianpopow
brianpopow approved these changes Feb 21, 2022
View reviewed changes
Copy link
Collaborator

@brianpopow brianpopow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JimBobSquarePants JimBobSquarePants merged commit 6727d6e into main Feb 21, 2022
@JimBobSquarePants JimBobSquarePants deleted the js/fix-2012 branch February 21, 2022 10:48
This was referenced Jul 23, 2025
Closed
Merged
Merged
Open
Open
Open
Open
Open
Open
Open
This was referenced Jul 30, 2025
Open
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Open
This was referenced Sep 23, 2025
Open
Open
This was referenced Oct 3, 2025
Open
Merged
Closed
Open
This was referenced Oct 19, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianpopow brianpopow brianpopow approved these changes

@antonfirsov antonfirsov Awaiting requested review from antonfirsov

Assignees

No one assigned

Labels

bug formats:gif metadata:xmp

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

Fail to Load a Gif Image with v2.0.0 but works with v1.0.4 on the same machine.

4 participants

@JimBobSquarePants @antonfirsov @brianpopow