-
-
Notifications
You must be signed in to change notification settings - Fork 888
Remove HistogramEqualizationOptions.Default #1840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HistogramEqualizationOptions.Default #1840
Conversation
|
|
||
| Assert.Equal(expected, actual); | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated tabs -> spaces change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this shouldn’t exist. Good catch!
Codecov Report
@@ Coverage Diff @@
## master #1840 +/- ##
======================================
Coverage 87% 87%
======================================
Files 937 937
Lines 48421 48420 -1
Branches 6054 6054
======================================
+ Hits 42223 42255 +32
+ Misses 5193 5160 -33
Partials 1005 1005
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Prerequisites
Description
We should not expose an arbitrary mutable variable like this. The common practice in the library is to use constructor to new-up instances of similar
XyzOptionsobjects.