Skip to content

Conversation

@antonfirsov
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

We should not expose an arbitrary mutable variable like this. The common practice in the library is to use constructor to new-up instances of similar XyzOptions objects.


Assert.Equal(expected, actual);
}
}
Copy link
Member Author

@antonfirsov antonfirsov Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated tabs -> spaces change.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this shouldn’t exist. Good catch!

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #1840 (83455e7) into master (9777a3b) will increase coverage by 0%.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1840   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         937     937           
  Lines       48421   48420    -1     
  Branches     6054    6054           
======================================
+ Hits        42223   42255   +32     
+ Misses       5193    5160   -33     
  Partials     1005    1005           
Flag Coverage Δ
unittests 87% <0%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/Normalization/HistogramEqualizationExtensions.cs 50% <0%> (ø)
...sors/Normalization/HistogramEqualizationOptions.cs 100% <ø> (+16%) ⬆️
...rc/ImageSharp/Formats/Webp/Lossless/Vp8LEncoder.cs 97% <0%> (-1%) ⬇️
.../ImageSharp/Formats/Webp/Lossless/LosslessUtils.cs 91% <0%> (+2%) ⬆️
...ageSharp/Formats/Webp/Lossless/PredictorEncoder.cs 91% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9777a3b...83455e7. Read the comment docs.

@antonfirsov antonfirsov merged commit 1ef54f9 into master Nov 19, 2021
@antonfirsov antonfirsov deleted the af/remove-HistogramEqualizationOptions-Default branch November 19, 2021 10:34
@JimBobSquarePants JimBobSquarePants added this to the 2.0.0 milestone Nov 19, 2021
This was referenced Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants