Skip to content

Conversation

@rold2007
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

I saw a clear typo in the code. So I added a new test which would validate the change. All the images used in the tests were previously grayscale so that the typo would go unnoticed. That being said, using adaptive thresholding on a color image is not a usual use case.

@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #1362 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1362   +/-   ##
=======================================
  Coverage   82.77%   82.77%           
=======================================
  Files         690      690           
  Lines       30975    30975           
  Branches     3511     3511           
=======================================
  Hits        25641    25641           
  Misses       4613     4613           
  Partials      721      721           
Flag Coverage Δ
#unittests 82.77% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Binarization/AdaptiveThresholdProcessor{TPixel}.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b06cb32...856d8af. Read the comment docs.

Copy link
Collaborator

@brianpopow brianpopow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rold2007 thank you for the fix!

@brianpopow brianpopow added the bug label Sep 26, 2020
@brianpopow brianpopow merged commit ee30c71 into SixLabors:master Sep 26, 2020
brianpopow added a commit that referenced this pull request Sep 26, 2020
@brianpopow brianpopow mentioned this pull request Sep 26, 2020
4 tasks
brianpopow added a commit that referenced this pull request Sep 26, 2020
JimBobSquarePants pushed a commit that referenced this pull request Mar 13, 2021
Fixed typo in AdaptiveThreshold
JimBobSquarePants pushed a commit that referenced this pull request Mar 13, 2021
JimBobSquarePants pushed a commit that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants