-
-
Notifications
You must be signed in to change notification settings - Fork 888
Fixed typo in AdaptiveThreshold #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1362 +/- ##
=======================================
Coverage 82.77% 82.77%
=======================================
Files 690 690
Lines 30975 30975
Branches 3511 3511
=======================================
Hits 25641 25641
Misses 4613 4613
Partials 721 721
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rold2007 thank you for the fix!
Add reference output for #1362
Fixed typo in AdaptiveThreshold
Add reference output for #1362
Prerequisites
Description
I saw a clear typo in the code. So I added a new test which would validate the change. All the images used in the tests were previously grayscale so that the typo would go unnoticed. That being said, using adaptive thresholding on a color image is not a usual use case.