-
-
Notifications
You must be signed in to change notification settings - Fork 888
Async version of DiscoverDecoder #1260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async version of DiscoverDecoder #1260
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1260 +/- ##
=======================================
Coverage 82.60% 82.61%
=======================================
Files 697 697
Lines 30521 30529 +8
Branches 3444 3445 +1
=======================================
+ Hits 25213 25221 +8
Misses 4603 4603
Partials 705 705
Continue to review full report at Codecov.
|
|
Thanks for this @pekspro I think simply transitioning the code internally as you have done is enough coverage for now.
We've an established pattern using |
Prerequisites
Description
It was no async version of DiscoverDecoder, so I added DiscoverDecoderAsync. Since async methods can’t have out parameters, I return a tuple instead. I would not mind doing the same change on DiscoverDecoder so they look the same.