Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Mar 29, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Spotted some issues while working on the API docs.

  • Made DeflateStrategy and DeflaterEnum internal
  • Moved GeometryUtilities to SixLabors.ImageSharp namespace.
  • Removed Implementation from SixLabors.ImageSharp.ColorSpaces.Conversion.Implementation

@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc1 milestone Mar 29, 2020
@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #1161 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1161   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files         681      681           
  Lines       29347    29347           
  Branches     3297     3297           
=======================================
  Hits        24145    24145           
  Misses       4514     4514           
  Partials      688      688           
Flag Coverage Δ
#unittests 82.27% <ø> (ø)
Impacted Files Coverage Δ
...c/ImageSharp/ColorSpaces/Companding/LCompanding.cs 0.00% <ø> (ø)
...olorSpaces/Conversion/ColorSpaceConverter.Adapt.cs 68.57% <ø> (ø)
...lorSpaces/Conversion/ColorSpaceConverter.CieLab.cs 100.00% <ø> (ø)
...lorSpaces/Conversion/ColorSpaceConverter.CieLch.cs 100.00% <ø> (ø)
...rSpaces/Conversion/ColorSpaceConverter.CieLchuv.cs 38.88% <ø> (ø)
...lorSpaces/Conversion/ColorSpaceConverter.CieLuv.cs 100.00% <ø> (ø)
...lorSpaces/Conversion/ColorSpaceConverter.CieXyy.cs 92.30% <ø> (ø)
...lorSpaces/Conversion/ColorSpaceConverter.CieXyz.cs 93.95% <ø> (ø)
...ColorSpaces/Conversion/ColorSpaceConverter.Cmyk.cs 84.61% <ø> (ø)
.../ColorSpaces/Conversion/ColorSpaceConverter.Hsl.cs 53.84% <ø> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c152bb...ac7dee0. Read the comment docs.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@JimBobSquarePants JimBobSquarePants merged commit 37fc697 into master Mar 29, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/visibility branch March 29, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants