-
-
Notifications
You must be signed in to change notification settings - Fork 888
Single row value delegate option #1132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single row value delegate option #1132
Conversation
|
@antonfirsov Mmmh, getting a very nice EDIT: all tests are passing just fine locally, I've bumped the CI. |
|
Can you run stress it a bit locally against net472? A PS script like this might do the job: |
|
@Sergio0694 What is the stack trace for that exception? I have a rich history of chasing them down in the jpeg decoder so I may prove useful. |
|
@JimBobSquarePants Ah crap, it was somewhere in the |
|
@Sergio0694 I had a look through the list of actions and I can't find anything other than the CoreFlags issues which have been fixed. https://github.com/SixLabors/ImageSharp/actions/runs/46311348 I've also thoroughly reviewed the code and there are no changes that you have made that could cause the introduction of an |
|
@JimBobSquarePants Sounds great, awesome! 😄 🚀 |
Prerequisites
Description
This PR reintroduces the single-row value delegates for pixel processors. It includes two new APIs for the
ParallelHelperclass, so that individual processor can choose whether to iterate over single rows or over row intervals, depending on their needs, so that it's possible to find the best possible balance between performance and code clarity.Opening this not as a draft PR just to have the CI run on it, but this is NOT READY TO MERGE.