Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Added pooled buffer generation to the edge class to make it threadsafe. Also did some very low hanging optimization fruit. Fix #1044

@jongleur1983 can you also have a look at the fix please to confirm. Thanks!

@codecov
Copy link

codecov bot commented Jan 11, 2020

Codecov Report

Merging #1079 into master will decrease coverage by <.01%.
The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1079      +/-   ##
==========================================
- Coverage   89.96%   89.95%   -0.01%     
==========================================
  Files        1200     1200              
  Lines       53010    53035      +25     
  Branches     3844     3846       +2     
==========================================
+ Hits        47689    47708      +19     
- Misses       4554     4560       +6     
  Partials      767      767
Impacted Files Coverage Δ
...harp.Tests/Drawing/FillLinearGradientBrushTests.cs 99.62% <100%> (+0.01%) ⬆️
...essing/Processors/Drawing/FillProcessor{TPixel}.cs 93.54% <100%> (ø) ⬆️
...c/ImageSharp.Drawing/Processing/BrushApplicator.cs 84.37% <37.5%> (-5.29%) ⬇️
...ImageSharp.Drawing/Processing/PathGradientBrush.cs 88% <79.16%> (-3.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a99d5...ebd09a0. Read the comment docs.

Copy link
Contributor

@jongleur1983 jongleur1983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test myself, but the code changes look good.
As I suggest the old tests still pass and the new one looks reasonable to reproduce the issue I approve these changes without testing myself.

@tocsoft tocsoft merged commit 1924acb into master Jan 11, 2020
@tocsoft tocsoft deleted the js/fix-1044 branch January 11, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weird wrong colors in gradients

4 participants