Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Touches #967

  • Refactor of IDisposable pattern for images, frames, and processors to work better with inheritance and ensure finalizer suppression.
  • Image<TPixel> is no longer sealed as that prevents extending for potential types like IntegralImage<TPixel>. ImageFrame<TPixel> is left sealed as inheritance should not be required.

@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #1009 into master will decrease coverage by 0.1%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
- Coverage   89.85%   89.74%   -0.11%     
==========================================
  Files        1098     1098              
  Lines       48823    48828       +5     
  Branches     3435     3435              
==========================================
- Hits        43870    43821      -49     
- Misses       4252     4254       +2     
- Partials      701      753      +52
Impacted Files Coverage Δ
src/ImageSharp/ImageExtensions.cs 68.42% <ø> (-2.32%) ⬇️
...rp/Processing/Processors/ImageProcessor{TPixel}.cs 100% <100%> (+9.67%) ⬆️
...essing/Processors/CloningImageProcessor{TPixel}.cs 82.05% <100%> (+2.05%) ⬆️
src/ImageSharp/ImageFrame.cs 100% <100%> (ø) ⬆️
src/ImageSharp/Image.cs 93.75% <100%> (-0.54%) ⬇️
src/ImageSharp/ImageFrame{TPixel}.cs 86.41% <33.33%> (-1.09%) ⬇️
src/ImageSharp/Image{TPixel}.cs 89.65% <88.88%> (-0.35%) ⬇️
...xelFormats/PixelOperations{TPixel}.PixelBenders.cs 89.9% <0%> (-10.1%) ⬇️
...olorSpaces/Conversion/ColorSpaceConverter.Adapt.cs 60% <0%> (-8.58%) ⬇️
...Processing/Processors/Transforms/TransformUtils.cs 87.64% <0%> (-6.75%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 644fe22...b0ef8a1. Read the comment docs.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with opening up the class hierarchy, otherwise looks good. See also:
https://twitter.com/marcgravell/status/1172053321386987520

@JimBobSquarePants
Copy link
Member Author

Gonna merge this without waiting for the build. I don't want to wait 40 minutes and we know it builds/passes tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants