Skip to content

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Aug 22, 2025

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentationchanges

Copy link
Contributor Author

isaacroldan commented Aug 22, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@isaacroldan isaacroldan changed the title Add new copy_files build mode and apply it to flow Use new copy_files build mode with Flow templates Aug 22, 2025
@isaacroldan isaacroldan force-pushed the 08-22-add_apply_new_build_mode_to_flow branch from 50d8352 to 83c55b8 Compare August 22, 2025 14:04
@isaacroldan isaacroldan force-pushed the 08-22-add_new_copy_files_build_mode branch from 8c0de77 to 1d8faaf Compare August 22, 2025 14:04
@isaacroldan isaacroldan force-pushed the 08-22-add_apply_new_build_mode_to_flow branch from 83c55b8 to 13812f2 Compare August 22, 2025 14:06
@isaacroldan isaacroldan force-pushed the 08-22-add_new_copy_files_build_mode branch from 1d8faaf to 2452642 Compare August 22, 2025 14:06
@isaacroldan isaacroldan force-pushed the 08-22-add_apply_new_build_mode_to_flow branch 2 times, most recently from e2cc36d to 9bbde93 Compare August 22, 2025 14:17
Copy link
Contributor

github-actions bot commented Aug 22, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.57% (-0.03% 🔻)
13438/17104
🟡 Branches
72.55% (+0.01% 🔼)
6521/8988
🟡 Functions
78.83% (+0.04% 🔼)
3500/4440
🟡 Lines
78.93% (-0.04% 🔻)
12700/16091
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / flags-validation.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / flow_template.ts
30.77% (-7.69% 🔻)
0%
0% (-20% 🔻)
30.77% (-7.69% 🔻)
🟢
... / urls.ts
80.41% (-1.83% 🔻)
74.29% (-3.21% 🔻)
75%
82.42% (-1.74% 🔻)
🟢
... / utilities.ts
97.96% (-0.04% 🔻)
80% (-1.82% 🔻)
80%
97.96% (-0.04% 🔻)
🔴
... / web.ts
46.43%
45.83% (-0.32% 🔻)
50% 50%
🟢
... / extension.ts
90.53% (-0.1% 🔻)
74.07% (+0.86% 🔼)
92%
90.32% (-0.1% 🔻)
🟢
... / liquid.ts
94.29%
81.25% (-6.25% 🔻)
100% 94.12%
🟡
... / local.ts
70% (-1.15% 🔻)
57.45% (-3.34% 🔻)
57.14%
70% (-1.15% 🔻)
🔴
... / console.ts
41.67% (-3.79% 🔻)
100% 0%
41.67% (-3.79% 🔻)
🔴
... / dev.ts
18.18% (-4.04% 🔻)
0% 0%
18.18% (-4.04% 🔻)
🔴
... / info.ts
20% (-3.08% 🔻)
0% 0%
20% (-3.08% 🔻)
🔴
... / profile.ts
29.41% (-1.84% 🔻)
0% 0%
29.41% (-1.84% 🔻)
🔴
... / theme-ui.ts
47.37% (-21.86% 🔻)
36.36% (-20.78% 🔻)
80% (-20% 🔻)
47.37% (-21.86% 🔻)

Test suite run success

3196 tests passing in 1345 suites.

Report generated by 🧪jest coverage report action from 7c0d909

@isaacroldan isaacroldan force-pushed the 08-22-add_new_copy_files_build_mode branch from 2452642 to 838606e Compare August 29, 2025 11:39
@isaacroldan isaacroldan force-pushed the 08-22-add_apply_new_build_mode_to_flow branch from 9bbde93 to 2bed3b6 Compare August 29, 2025 11:39
@isaacroldan isaacroldan force-pushed the 08-22-add_apply_new_build_mode_to_flow branch from 2bed3b6 to 7c0d909 Compare August 29, 2025 15:09
@isaacroldan isaacroldan mentioned this pull request Aug 29, 2025
5 tasks
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/base-command.d.ts
@@ -32,17 +32,4 @@ export declare function addFromParsedFlags(flags: {
     path?: string;
     verbose?: boolean;
 }): Promise<void>;
-/**
- * Strips the defaults from configured flags. For example, if flags contains:
- *
- * 
- *
- * it becomes:
- *
- * 
- *
- * If we parse using this configuration, the only specified flags will be those
- * the user actually passed on the command line.
- */
-export declare function noDefaultsOptions<TFlags extends FlagOutput, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(options: Input<TFlags, TGlobalFlags, TArgs> | undefined): Input<TFlags, TGlobalFlags, TArgs> | undefined;
 export default BaseCommand;
\ No newline at end of file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant