Skip to content

Conversation

adamtroiani
Copy link

@adamtroiani adamtroiani commented Aug 11, 2025

WHY are these changes introduced?

Fixes shop/issues-shopifyvm#434

WHAT is this pull request doing?

Adds "graphql-codegen/cli" dependency to CLI in order to call generate function instead of shelling out to npm exec.

How to test your changes?

  1. Create shopify app (remix and extension-only)
  2. dev cd cli && git checkout at.graphql-codegen-pnpm-fix-2
  3. pnpm shopify app extension generate --path <path to app created in step 1>
  4. Should see success message after generating any extension

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

@adamtroiani adamtroiani self-assigned this Aug 11, 2025
@adamtroiani adamtroiani marked this pull request as ready for review August 11, 2025 16:30
@adamtroiani adamtroiani requested a review from a team as a code owner August 11, 2025 16:30
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

Copy link
Contributor

github-actions bot commented Aug 11, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.56% (-0.01% 🔻)
13452/17124
🟡 Branches
72.48% (-0% 🔻)
6555/9044
🟡 Functions
78.76% (-0.01% 🔻)
3501/4445
🟡 Lines
78.93% (-0.01% 🔻)
12719/16115
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / analytics.ts
100% 100% 100% 100%
🟢
... / bounded-collections.ts
100% 87.5% 100% 100%
🟢
... / error-categorizer.ts
100% 100% 100% 100%
🟢
... / storage.ts
96.55% 87.5% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / build.ts
71.83% (+0.09% 🔼)
58.33% (-0.36% 🔻)
69.05%
70.9% (+0.13% 🔼)
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
92% (-4% 🔻)
100%
98.33% (-1.67% 🔻)
🟡
... / api.ts
66.28% (-0.39% 🔻)
50.62% 65.71%
68.1% (-0.39% 🔻)
🔴
... / delete.ts
35.71% (-26.79% 🔻)
0% 0%
35.71% (-26.79% 🔻)
🟢
... / local-storage.ts
100%
54.55% (-3.79% 🔻)
100% 100%
🟢
... / pull.ts
96.3% (-0.48% 🔻)
69.7% 100%
96.15% (-0.51% 🔻)
🟢
... / push.ts
94.52% (-0.28% 🔻)
80.65% 100%
94.44% (-0.29% 🔻)
🟢
... / theme-command.ts
81.32% (-2.49% 🔻)
57.78% (-3.45% 🔻)
78.26% (-4.5% 🔻)
83.33% (-1.93% 🔻)
🟢
... / theme-uploader.ts
93.14% (-0.08% 🔻)
79.63% 92.19%
94.23% (-0.07% 🔻)

Test suite run success

3226 tests passing in 1352 suites.

Report generated by 🧪jest coverage report action from 1fb9281

@adamtroiani adamtroiani force-pushed the at.graphql-codegen-pnpm-fix-2 branch from 87d3582 to ab37a2a Compare August 11, 2025 16:48
@adamtroiani
Copy link
Author

/snapit

Copy link
Contributor

🫰✨ Thanks @adamtroiani! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@adamtroiani adamtroiani force-pushed the at.graphql-codegen-pnpm-fix-2 branch from ab37a2a to 8cc83bb Compare August 12, 2025 15:49
@adamtroiani
Copy link
Author

/snapit

Copy link
Contributor

🫰✨ Thanks @adamtroiani! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@adamtroiani adamtroiani force-pushed the at.graphql-codegen-pnpm-fix-2 branch from 8cc83bb to fa7558d Compare August 12, 2025 15:59
@adamtroiani
Copy link
Author

/snapit

Copy link
Contributor

🫰✨ Thanks @adamtroiani! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@adamtroiani adamtroiani force-pushed the at.graphql-codegen-pnpm-fix-2 branch from fa7558d to 43d038e Compare August 12, 2025 17:51
@adamtroiani
Copy link
Author

/snapit

Copy link
Contributor

🫰✨ Thanks @adamtroiani! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@adamtroiani adamtroiani force-pushed the at.graphql-codegen-pnpm-fix-2 branch from cca99a4 to 47e58c6 Compare August 21, 2025 18:10
@adamtroiani
Copy link
Author

/snapit

Copy link
Contributor

🫰✨ Thanks @adamtroiani! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@adamtroiani adamtroiani force-pushed the at.graphql-codegen-pnpm-fix-2 branch from 47e58c6 to 14a0ca4 Compare August 22, 2025 13:52
@adamtroiani
Copy link
Author

/snapit

Copy link
Contributor

🫰✨ Thanks @adamtroiani! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@adamtroiani adamtroiani force-pushed the at.graphql-codegen-pnpm-fix-2 branch from 14a0ca4 to 1fb9281 Compare August 22, 2025 14:18
@lopert lopert self-assigned this Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants