-
Notifications
You must be signed in to change notification settings - Fork 202
Extension generation via pnpm fixed #6242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3226 tests passing in 1352 suites. Report generated by 🧪jest coverage report action from 1fb9281 |
87d3582
to
ab37a2a
Compare
/snapit |
🫰✨ Thanks @adamtroiani! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g @shopify/[email protected] Tip If you get an Caution After installing, validate the version by running just |
ab37a2a
to
8cc83bb
Compare
/snapit |
🫰✨ Thanks @adamtroiani! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g @shopify/[email protected] Tip If you get an Caution After installing, validate the version by running just |
8cc83bb
to
fa7558d
Compare
/snapit |
🫰✨ Thanks @adamtroiani! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g @shopify/[email protected] Tip If you get an Caution After installing, validate the version by running just |
fa7558d
to
43d038e
Compare
/snapit |
🫰✨ Thanks @adamtroiani! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g @shopify/[email protected] Tip If you get an Caution After installing, validate the version by running just |
cca99a4
to
47e58c6
Compare
/snapit |
🫰✨ Thanks @adamtroiani! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g @shopify/[email protected] Tip If you get an Caution After installing, validate the version by running just |
47e58c6
to
14a0ca4
Compare
/snapit |
🫰✨ Thanks @adamtroiani! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g @shopify/[email protected] Tip If you get an Caution After installing, validate the version by running just |
14a0ca4
to
1fb9281
Compare
WHY are these changes introduced?
Fixes shop/issues-shopifyvm#434
WHAT is this pull request doing?
Adds "graphql-codegen/cli" dependency to CLI in order to call
generate
function instead of shelling out tonpm exec
.How to test your changes?
dev cd cli && git checkout at.graphql-codegen-pnpm-fix-2
pnpm shopify app extension generate --path <path to app created in step 1>
Measuring impact
How do we know this change was effective? Please choose one: