Skip to content

Conversation

cgoldberg
Copy link
Contributor

@cgoldberg cgoldberg commented Jul 21, 2025

User description

🔗 Related Issues

Fixes #16077

💥 What does this PR do?

This PR changes the vendor prefix for Edge to ms (from goog) so webdriver.Remote methods work correctly with Edge.

🔄 Types of changes

  • Bug fix (backwards compatible)

PR Type

Bug fix


Description

  • Fix vendor prefix for Edge browser from goog to ms

  • Enables proper functionality of webdriver.Remote methods with Edge


Diagram Walkthrough

flowchart LR
  A["Edge Remote Connection"] --> B["Vendor Prefix Change"]
  B --> C["goog → ms"]
  C --> D["Fixed Remote Methods"]
Loading

File Walkthrough

Relevant files
Bug fix
remote_connection.py
Update vendor prefix for Edge                                                       

py/selenium/webdriver/edge/remote_connection.py

  • Changed vendor prefix parameter from "goog" to "ms" in
    EdgeRemoteConnection constructor
+1/-1     

Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Vendor Prefix

Verify that changing the vendor prefix from "goog" to "ms" is correct for Edge browser and doesn't break existing functionality. Ensure this aligns with Edge WebDriver specifications and that all Edge-specific remote methods will work properly with the new prefix.

vendor_prefix="ms",
browser_name=EdgeRemoteConnection.browser_name,

Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@selenium-ci selenium-ci added the C-py Python Bindings label Jul 21, 2025
Copy link
Member

@Delta456 Delta456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@cgoldberg cgoldberg merged commit 849b553 into SeleniumHQ:trunk Jul 21, 2025
18 of 19 checks passed
@cgoldberg cgoldberg deleted the py-edge-remote-vendor-prefix branch July 22, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: [py] execute_cdp_cmd not working in Remote Edge browser
3 participants