[py] Use pinned browsers for bidi webextension tests

[cgoldberg]

User description

💥 What does this PR do?

This PR updates the chromium_driver fixture used in the tests in bidi_webextension_tests.py so they use the --browser-binary and --driver-binary args passed by bazel. This will allow these tests to use pinned browsers when running in RBE.

🔄 Types of changes

• Build/Test

---

PR Type

Tests

---

Description

• Update chromium driver fixture to use pinned browsers

• Add support for browser binary and driver executable paths

• Enable RBE compatibility for BiDi webextension tests

---

Diagram Walkthrough

flowchart LR
  A["Test Configuration"] --> B["Browser Binary Path"]
  A --> C["Driver Executable Path"]
  B --> D["Chromium Options"]
  C --> E["Browser Service"]
  D --> F["Chromium Driver"]
  E --> F

Loading

File Walkthrough

	Relevant files
Tests	bidi_webextension_tests.py Configure pinned browser support for chromium driver          py/test/selenium/webdriver/common/bidi_webextension_tests.py Added browser service class selection for Chrome/Edge Implemented binary location configuration from test options Added executable path support for driver service Updated temp directory prefix to be more generic +14/-2

---

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Missing Cleanup The temporary directory created with tempfile.mkdtemp() is not being cleaned up after the test completes. This could lead to disk space issues over time as temporary directories accumulate. temp_dir = tempfile.mkdtemp(prefix="chromium-profile-") chromium_options.enable_bidi = True chromium_options.enable_webextensions = True chromium_options.add_argument(f"--user-data-dir={temp_dir}") Undefined Variable The variable temp_dir is used on line 144 but is only defined within the conditional block on line 140. This will cause a NameError if the code path doesn't execute the assignment. temp_dir = tempfile.mkdtemp(prefix="chromium-profile-") chromium_options.enable_bidi = True chromium_options.enable_webextensions = True chromium_options.add_argument(f"--user-data-dir={temp_dir}")

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Handle unsupported driver options Add an else clause to handle unsupported driver options. Without this, browser_service could be undefined if an unexpected driver option is passed, leading to a NameError when creating the service. py/test/selenium/webdriver/common/bidi_webextension_tests.py [133-138] if driver_option == "chrome": browser_class = webdriver.Chrome browser_service = webdriver.ChromeService elif driver_option == "edge": browser_class = webdriver.Edge browser_service = webdriver.EdgeService +else: + raise ValueError(f"Unsupported driver option: {driver_option}") Apply / Chat Suggestion importance[1-10]: 7 __ Why: The suggestion correctly points out that if driver_option is not 'chrome' or 'edge', browser_service will be unassigned, leading to a NameError. Adding an else clause to handle this case improves the code's robustness.	Medium
Update

[cgoldberg]

The 3 CI failures are unrelated to this change.