Skip to content

Conversation

cgoldberg
Copy link
Contributor

@cgoldberg cgoldberg commented Jul 9, 2025

💥 What does this PR do?

This PR fixes the test_get_connection_manager_for_certs_and_timeout test. It was failing on Windows due to a hardcoded path separator.

🔄 Types of changes

  • Unit tests
  • Bug fix (backwards compatible)

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @selenium-ci selenium-ci added the C-py Python Bindings label Jul 9, 2025
    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 9, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @SeleniumHQ SeleniumHQ deleted a comment from qodo-merge-pro bot Jul 9, 2025
    @cgoldberg cgoldberg merged commit db00a84 into SeleniumHQ:trunk Jul 10, 2025
    16 checks passed
    @cgoldberg cgoldberg deleted the py-fix-unit-test-cert-path branch July 10, 2025 13:15
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants