Skip to content

Conversation

noritaka1166
Copy link
Contributor

@noritaka1166 noritaka1166 commented Jul 9, 2025

User description

🔗 Related Issues

💥 What does this PR do?

Fix typos in dotnet

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes


PR Type

Other


Description

  • Fix spelling errors across .NET codebase

  • Correct typos in comments and documentation

  • Update variable names and method descriptions

  • Fix changelog spelling mistakes


Changes diagram

flowchart LR
  A["Source Files"] --> B["Fix Spelling Errors"]
  B --> C["Update Comments"]
  B --> D["Fix Documentation"]
  B --> E["Correct Variable Names"]
  F["Test Files"] --> B
  G["Changelog"] --> B
Loading

Changes walkthrough 📝

Relevant files
Miscellaneous
17 files
ChromiumOptions.cs
Fix "exeption" to "exception" typo                                             
+2/-2     
CommandResponseExtensions.cs
Fix "impelementing" to "implementing" typo                             
+1/-1     
ConsoleApiCalledEventArgs.cs
Fix "stanp" to "stamp" typo                                                           
+2/-2     
DevToolsSession.cs
Fix "wont" to "won't" typo                                                             
+1/-1     
DriverService.cs
Fix "resposne" to "response" typo                                               
+1/-1     
FirefoxExtension.cs
Fix "temporarly" and "extenion" typos                                       
+2/-2     
GlobalSuppressions.cs
Fix "propert" to "property" typo                                                 
+1/-1     
PointerInputDevice.cs
Fix "proprties" to "properties" typo                                         
+1/-1     
ILogContext.cs
Fix "emmiting" to "emitting" typo                                               
+1/-1     
ILogger.cs
Fix "emmiting" to "emitting" typo                                               
+1/-1     
PinnedScript.cs
Fix "perview" to "preview" typo                                                   
+1/-1     
PrintOptions.cs
Fix "doucment" to "document" typo                                               
+1/-1     
CookieImplementationTest.cs
Fix "dalmation" and "Reenable" typos                                         
+2/-2     
UnexpectedAlertBehaviorTest.cs
Fix "acknowldegement" to "acknowledgement" typo                   
+1/-1     
VirtualAuthenticatorTest.cs
Fix "non-existant" to "non-existent" typo                               
+1/-1     
WindowSwitchingTest.cs
Fix "non-existant" to "non-existent" typo                               
+1/-1     
CHANGELOG
Fix multiple spelling errors throughout changelog               
+30/-30 

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @selenium-ci selenium-ci added the C-dotnet .NET Bindings label Jul 9, 2025
    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 9, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ❌

    1234 - Not compliant

    Non-compliant requirements:

    • Fix JavaScript execution issue in Firefox 42.0 where click() on links with JavaScript href doesn't trigger properly
    • Ensure compatibility between Selenium 2.47.1 and 2.48.x versions for JavaScript link handling
    • Address regression where alerts are not triggered in 2.48.0/2.48.2 but work in 2.47.1

    5678 - Not compliant

    Non-compliant requirements:

    • Fix ChromeDriver connection failure error "ConnectFailure (Connection refused)"
    • Resolve issue occurring on Ubuntu 16.04.4 with Chrome 65.0.3325.181 and ChromeDriver 2.35
    • Address problem where first ChromeDriver instance works but subsequent instances fail
    • Provide solution for Selenium 3.9.0 compatibility

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 9, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Fix incorrect word usage
    Suggestion Impact:The suggestion was directly implemented - the word "preview" was changed to "purview" in the comment exactly as suggested

    code diff:

    -    /// is strictly the preview of Selenium, and should not be required by external
    +    /// is strictly the purview of Selenium, and should not be required by external

    The word "preview" should be "purview" in this context. "Purview" means the
    scope or range of authority, while "preview" means a preliminary view or
    showing.

    dotnet/src/webdriver/PinnedScript.cs [36-40]

     /// <remarks>
     /// This constructor is explicitly internal. Creation of pinned script objects
    -/// is strictly the preview of Selenium, and should not be required by external
    +/// is strictly the purview of Selenium, and should not be required by external
     /// libraries.
     /// </remarks>

    [Suggestion processed]

    Suggestion importance[1-10]: 3

    __

    Why: The suggestion correctly identifies that the word preview is used incorrectly in the comment, and the correct word should be purview.

    Low
    • Update

    @cgoldberg cgoldberg changed the title Fix typos in dotnet [dotnet] Fix typos Jul 9, 2025
    Copy link
    Contributor

    @cgoldberg cgoldberg left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @cgoldberg cgoldberg merged commit 9c40e0e into SeleniumHQ:trunk Jul 9, 2025
    1 check passed
    @noritaka1166 noritaka1166 deleted the fix-dotnet-typos branch July 9, 2025 12:43
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants