Skip to content

Conversation

noritaka1166
Copy link
Contributor

@noritaka1166 noritaka1166 commented Jul 8, 2025

User description

🔗 Related Issues

💥 What does this PR do?

Fix typos in java & scripts

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes


PR Type

Other


Description

  • Fix typos in Java documentation and script comments

  • Correct "indention" to "indentation" in JsonOutput

  • Fix "preform" to "perform" in RetryRequest

  • Correct "dependendencies" to "dependencies" in shell script


Changes diagram

flowchart LR
  A["Java Files"] --> B["Fix Documentation Typos"]
  C["Shell Script"] --> D["Fix Comment Typos"]
  B --> E["Improved Code Quality"]
  D --> E
Loading

Changes walkthrough 📝

Relevant files
Documentation
JsonOutput.java
Fix documentation typo in JsonOutput                                         

java/src/org/openqa/selenium/json/JsonOutput.java

  • Fixed typo "indention" to "indentation" in JavaDoc comment
+1/-1     
RetryRequest.java
Fix comment typo in RetryRequest                                                 

java/src/org/openqa/selenium/remote/http/RetryRequest.java

  • Fixed typo "preform" to "perform" in inline comment
+1/-1     
update_py_dependencies.sh
Fix typo in shell script comment                                                 

scripts/update_py_dependencies.sh

  • Fixed typo "dependendencies" to "dependencies" in script header
    comment
  • +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @selenium-ci selenium-ci added C-java Java Bindings B-build Includes scripting, bazel and CI integrations labels Jul 8, 2025
    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 8, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ❌

    5678 - Not compliant

    Non-compliant requirements:

    • Fix ChromeDriver connection failure error that occurs after first instance
    • Resolve "Error: ConnectFailure (Connection refused)" issue
    • Address issue specific to Ubuntu 16.04.4, Chrome 65.0.3325.181, ChromeDriver 2.35, Selenium 3.9.0

    1234 - Not compliant

    Non-compliant requirements:

    • Fix JavaScript execution in link's href attribute when using click() method
    • Restore functionality that worked in version 2.47.1 but broke in 2.48.0 and 2.48.2
    • Address Firefox 42.0 compatibility issue

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Typo Fix

    The JavaDoc comment contains a typo "br" instead of "be" in the phrase "should br formatted"

    * Specify whether the serialized JSON object should br formatted with line breaks and indentation
    * ("pretty printed").

    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 8, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Fix typo in JavaDoc comment
    Suggestion Impact:The suggestion was directly implemented - the typo "br" was corrected to "be" in the JavaDoc comment

    code diff:

    -   * Specify whether the serialized JSON object should br formatted with line breaks and indentation
    +   * Specify whether the serialized JSON object should be formatted with line breaks and indentation

    Fix the typo "br" to "be" in the JavaDoc comment. The word "br" should be "be"
    to make the sentence grammatically correct.

    java/src/org/openqa/selenium/json/JsonOutput.java [267]

    -* Specify whether the serialized JSON object should br formatted with line breaks and indentation
    +* Specify whether the serialized JSON object should be formatted with line breaks and indentation

    [Suggestion processed]

    Suggestion importance[1-10]: 4

    __

    Why: The suggestion correctly identifies a typo ('br' should be 'be') in the Javadoc comment on a line modified by the PR, which improves documentation clarity.

    Low
    • Update

    @cgoldberg cgoldberg changed the title Fix typos in java & scripts Fix various typos in comments Jul 8, 2025
    cgoldberg and others added 2 commits July 8, 2025 08:20
    Co-authored-by: qodo-merge-pro[bot] <151058649+qodo-merge-pro[bot]@users.noreply.github.com>
    Copy link
    Contributor

    @cgoldberg cgoldberg left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM... thanks.

    @cgoldberg cgoldberg merged commit 85faa75 into SeleniumHQ:trunk Jul 8, 2025
    1 check passed
    @noritaka1166 noritaka1166 deleted the fix-java-and-scripts-typo branch July 8, 2025 12:22
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    B-build Includes scripting, bazel and CI integrations C-java Java Bindings Review effort 1/5
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants