[grid] Add "URI" to the list of sort-by choices on Overview UI

[VietND96]

User description

🔗 Related Issues

Fixes #15955

💥 What does this PR do?

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

• Cleanup (formatting, renaming)
• Bug fix (backwards compatible)
• New feature (non-breaking change which adds functionality and tests!)
• Breaking change (fix or feature that would cause existing functionality to change)

---

PR Type

Enhancement

---

Description

• Add URI sorting option to Grid Overview UI

• Include URI comparison function in sort properties

• Add test coverage for URI sorting functionality

---

Changes diagram

flowchart LR
  A["Overview UI"] --> B["Sort Properties"]
  B --> C["Add URI Option"]
  C --> D["URI Comparison Function"]
  D --> E["Updated Sort Labels"]
  F["Test Suite"] --> G["URI Sort Test"]

Loading

---

Changes walkthrough 📝

	Relevant files
Enhancement	Overview.tsx Add URI sorting functionality                                                        javascript/grid-ui/src/screens/Overview/Overview.tsx Add uri property to sortProperties object with comparison function Add URI label to sortPropertiesLabel mapping +2/-0
Tests	Overview.test.tsx Add URI sorting test                                                                          javascript/grid-ui/src/tests/components/Overview.test.tsx Add test case for URI sorting functionality Verify nodes are sorted correctly by URI when selected +20/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Missing Validation The URI comparison function assumes all nodes have a uri property. If a node lacks this property, the comparison will fail with a runtime error. Consider adding null/undefined checks or default values. 'uri': (a, b) => a.uri.localeCompare(b.uri), 'browserName': (a, b) => compareSlotStereotypes(a, b, 'browserName'), Test Fragility The test relies on specific URI ordering and regex matching that could be brittle. The test assumes nodes will always have the exact URIs specified and may fail if mock data changes. const nodeUris = screen.getAllByText(/http:\/\/192\.168\.1\.\d+:4444/) expect(nodeUris[0]).toHaveTextContent('http://192.168.1.10:4444') expect(nodeUris[1]).toHaveTextContent('http://192.168.1.11:4444')

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Add null safety for URI comparison Add null safety checks for the uri property before calling localeCompare. If either node's uri is undefined or null, the comparison will throw an error. javascript/grid-ui/src/screens/Overview/Overview.tsx [70] -'uri': (a, b) => a.uri.localeCompare(b.uri), +'uri': (a, b) => (a.uri || '').localeCompare(b.uri || ''), Apply / Chat Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies that calling localeCompare on a potentially null or undefined uri would cause a runtime error and provides a robust fix.	Medium
Update

[Copilot]

Pull Request Overview

This PR enhances the Grid Overview UI by adding URI as a sortable column and covering its functionality with a new test.

• Introduce a uri comparator to the sort properties
• Add the “URI” label to the sort dropdown
• Add a test to verify ascending URI sorting

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
javascript/grid-ui/src/screens/Overview/Overview.tsx	Add uri comparator and label to sortProperties
javascript/grid-ui/src/tests/components/Overview.test.tsx	Add test case for URI sorting functionality

Comments suppressed due to low confidence (1)

javascript/grid-ui/src/tests/components/Overview.test.tsx:258

• [nitpick] Consider adding a test case to verify sorting in descending order when the 'Descending' checkbox is checked, ensuring full coverage of both sort directions for the URI option.

  it('sorts nodes by URI when selected', async () => {

[cdsontag]

Thank you @VietND96 !! Will these changes make it into grid 4.35?