-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[py][java][rb][ci]: use pinned browsers in CI #15987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Python tests already use the pinned browsers in the RBE workflow. Why do we need this? |
@diemol the integration tests don't use the pinned browsers. They use the default browsers which github runner comes with. This is not for RBE, they already use the pinned browsers. For example, currently github runners are using chrome 137 but RBE is using 138 which is latest stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't think of any reason why we would want to stay on older browsers if new ones are available, so LGTM.
OK, we can try it. But then let's do it for all languages. Otherwis,e we keep doing things differently. |
Dotnet already uses it. |
@diemol I have updated the CI for java and ruby also. Only 1 test is failing for java FedCM which is expected. I see that the tests were ignored in this commit but later removed here after adding the test to |
Any idea why adding |
Disabled the FedCM tests to resolve the issue. |
User description
🔗 Related Issues
💥 What does this PR do?
Allows bazel to use pinned browsers in CI so the tests run against the latest browsers specified in
repositories.bzl
file.GitHub runners don't get the latest stable browser immediately after release, it usually takes a few weeks. This hinders development since tests don't pass.
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement
Description
Add
--pin_browsers=true
flag to Python CI testsEnsures tests run against latest browsers from
repositories.bzl
Fixes CI failures due to delayed browser updates on GitHub runners
Changes diagram
Changes walkthrough 📝
ci-python.yml
Add pinned browsers flag to CI tests
.github/workflows/ci-python.yml
--pin_browsers=true
flag to all bazel test commands