Skip to content

Conversation

cgoldberg
Copy link
Contributor

@cgoldberg cgoldberg commented Jun 29, 2025

User description

💥 What does this PR do?

This PR updates the Python dependencies listed in py/BUILD.bazel (py_wheel task). This is the dependency list used to build the Python wheel for distribution on PyPI.

This was previously updated in py/requirements.txt and py/pyproject.toml (used for testing and local development), but it was not reflected in the wheel we are building.

💡 Additional Considerations

Since this was not updated, Selenium 4.34 package was released with the old urllib3[socks]~=2.4.0 dependency specifier listed. Anyone installing version 4.34 will get the old urllib3 package. Assuming this PR gets merged, the updated dependency specifier will be included in the next (4.35) release.

🔄 Types of changes

  • Build Dependency

PR Type

Other


Description

  • Update urllib3[socks] dependency from ~=2.4.0 to ~=2.5.0

  • Update certifi dependency from >=2025.4.26 to >=2025.6.15

  • Synchronize wheel build dependencies with development requirements


Changes diagram

flowchart LR
  A["py/BUILD.bazel"] --> B["urllib3[socks] ~=2.5.0"]
  A --> C["certifi >=2025.6.15"]
  B --> D["PyPI wheel distribution"]
  C --> D
Loading

Changes walkthrough 📝

Relevant files
Dependencies
BUILD.bazel
Bump wheel build dependencies                                                       

py/BUILD.bazel

  • Updated urllib3[socks] dependency from ~=2.4.0 to ~=2.5.0
  • Updated certifi dependency from >=2025.4.26 to >=2025.6.15
  • +2/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @selenium-ci selenium-ci added C-py Python Bindings B-build Includes scripting, bazel and CI integrations labels Jun 29, 2025
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @cgoldberg cgoldberg merged commit 9c0e287 into SeleniumHQ:trunk Jun 29, 2025
    20 checks passed
    @cgoldberg cgoldberg deleted the py-bump-wheel-dependencies branch June 29, 2025 23:43
    @Houbein
    Copy link

    Houbein commented Jul 3, 2025

    @cgoldberg Is it possible to make a Python hotfix release of this? I'd rather not wait 2 months for the next major release.

    @cgoldberg
    Copy link
    Contributor Author

    @Houbein yes, 4.34.1 should be published soon

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    B-build Includes scripting, bazel and CI integrations C-py Python Bindings Review effort 1/5
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants