Skip to content

[JS] Bidi Support #11395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Dec 21, 2022
Merged

[JS] Bidi Support #11395

merged 19 commits into from
Dec 21, 2022

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Dec 9, 2022 •
edited
Loading

Description

  • Adds initial BIDI support

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@harsha509 harsha509 marked this pull request as ready for review December 16, 2022 14:21
@pujagani pujagani added this to the 4.8 milestone Dec 19, 2022
@pujagani pujagani added C-nodejs JavaScript Bindings B-devtools Includes everything BiDi or Chrome DevTools related labels Dec 19, 2022
@pujagani
Copy link
Contributor

LGTM from BiDi spec perspective. Adding a filter to the log inspector APIs would be a follow-up PR to keep things easier to review.

potapovDim
potapovDim reviewed Dec 19, 2022
View reviewed changes
AutomatedTester
AutomatedTester reviewed Dec 19, 2022
View reviewed changes
potapovDim
potapovDim reviewed Dec 19, 2022
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pujagani pujagani merged commit 3f70670 into SeleniumHQ:trunk Dec 21, 2022
@dtopuzov dtopuzov mentioned this pull request Feb 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AutomatedTester AutomatedTester AutomatedTester left review comments

+1 more reviewer

@potapovDim potapovDim potapovDim left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
B-devtools Includes everything BiDi or Chrome DevTools related C-nodejs JavaScript Bindings
Projects
None yet
Milestone
4.8
Development

Successfully merging this pull request may close these issues.
5 participants
@harsha509 @pujagani @AutomatedTester @potapovDim @TamsilAmani