Add DAEProblem specialization for remake with initialization_data support #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port This commit adds a specialized remake function for DAEProblem that properly handles initialization_data, matching the pattern used in ODEProblem, SDEProblem, and other problem types. The new remake function: - Accepts all DAEProblem-specific parameters (du0, differential_vars) - Handles initialization_data creation and passing through remake - Supports lazy_initialization and build_initializeprob flags - Maintains compatibility with existing API This enables proper initialization handling for DAE problems when using Sundials.jl CheckInit functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
remakefunction forDAEProblemthat properly handlesinitialization_dataChanges
remake(prob::DAEProblem; ...)function insrc/remake.jldu0,differential_varsinitialization_datacreation and passing through remakelazy_initializationandbuild_initializeprobflagsMotivation
This change is required to support the CheckInit functionality in Sundials.jl (see PR #503) for DAE problems. Without this specialization, the initialization_data was not being properly handled when remaking DAE problems, which prevented proper initialization checks.
Testing
Basic testing confirms the remake function works correctly:
Full integration testing with Sundials.jl CheckInit will be possible once both PRs are merged.
Related to: SciML/Sundials.jl#503
🤖 Generated with Claude Code