Fix OptimizationFunction{false} isinplace check #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove isinplace call from OptimizationFunction{iip} constructor when
iip is explicitly provided. This matches the behavior of ODEFunction
and fixes issue SciML#1103 where functions that fail isinplace checks
(like compiled Reactant functions) cannot be used even when the user
explicitly specifies the iip parameter.
The isinplace check is kept for the non-parameterized
OptimizationFunction constructor where it's needed to infer the iip value.
Fixes SciML#1103
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
isinplacecheck fromOptimizationFunction{iip}constructor wheniipis explicitly providedODEFunction{iip}which already handles this correctlyProblem
OptimizationFunction{false}was still callingisinplace(f, 2)even when the user explicitly provided theiip=falsetype parameter. This prevented users from creatingOptimizationFunctionobjects with functions that fail theisinplacecheck (such as compiled Reactant functions), even when they know the function signature and want to bypass the automatic detection.Solution
isinplacecall from line 4282 in theOptimizationFunction{iip}constructorisinplacecall in the non-parameterizedOptimizationFunctionconstructor where it's needed to infer theiipvalueOptimizationFunction{false}andOptimizationFunction{true}work without triggeringisinplacechecksTest plan
OptimizationFunction{iip}can be created with functions that would failisinplacechecksODEFunction{iip}patternsFixes #1103
🤖 Generated with Claude Code