Skip to content

Conversation

@ValentinKaisermayer
Copy link
Contributor

No description provided.

@ChrisRackauckas
Copy link
Member

Bump the symbolics lower bound?

@ValentinKaisermayer
Copy link
Contributor Author

ValentinKaisermayer commented Aug 20, 2022

Seems to be an MTK issue with inputs_to_parameters! and array variables. The StateSpace block is the only one using it.
@baggepinnen can you have a look?

@ValentinKaisermayer
Copy link
Contributor Author

Why doesn't the downstream test fail in MTK?

@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #99 (41bf9cf) into main (20366a7) will increase coverage by 1.31%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   65.60%   66.92%   +1.31%     
==========================================
  Files          23       24       +1     
  Lines        1006     1052      +46     
==========================================
+ Hits          660      704      +44     
- Misses        346      348       +2     
Impacted Files Coverage Δ
src/Blocks/utils.jl 57.14% <50.00%> (ø)
src/Blocks/continuous.jl 98.17% <100.00%> (ø)
src/Mechanical/Rotational/sources.jl 85.00% <0.00%> (-15.00%) ⬇️
src/Mechanical/Rotational/sensors.jl 100.00% <0.00%> (ø)
src/Mechanical/Rotational/utils.jl 73.46% <0.00%> (+2.04%) ⬆️
src/Mechanical/Rotational/components.jl 88.88% <0.00%> (+2.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas
Copy link
Member

Seems like a real failure?

@ValentinKaisermayer
Copy link
Contributor Author

Seems like a real failure?

Yes, but in MTK.

@YingboMa YingboMa merged commit a8bb688 into SciML:main Sep 14, 2022
@ValentinKaisermayer ValentinKaisermayer deleted the fix-array-symbolics branch September 14, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants