Skip to content

Conversation

@ven-k
Copy link
Member

@ven-k ven-k commented Aug 14, 2023

@ven-k ven-k force-pushed the vkb/extend-kwargs branch from 97b3b83 to a8021bd Compare August 14, 2023 09:18
@ven-k ven-k marked this pull request as ready for review August 29, 2023 19:44
@YingboMa YingboMa closed this Sep 4, 2023
@YingboMa YingboMa reopened this Sep 4, 2023
@ven-k ven-k force-pushed the vkb/extend-kwargs branch from dfecae8 to 2ca7936 Compare September 4, 2023 15:47
Copy link
Member

@YingboMa YingboMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a bound on MTK as well.

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #209 (3f63e66) into main (a99b91d) will increase coverage by 0.10%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   55.00%   55.10%   +0.10%     
==========================================
  Files          48       48              
  Lines        1620     1617       -3     
==========================================
  Hits          891      891              
+ Misses        729      726       -3     
Files Changed Coverage Δ
src/Blocks/nonlinear.jl 84.61% <ø> (ø)
src/Electrical/Analog/ideal_components.jl 0.00% <0.00%> (ø)
src/Mechanical/Rotational/components.jl 54.54% <ø> (ø)
src/Mechanical/Rotational/sources.jl 71.42% <ø> (ø)
src/Mechanical/Translational/components.jl 47.72% <ø> (ø)
src/Mechanical/TranslationalModelica/components.jl 0.00% <ø> (ø)
src/Mechanical/TranslationalPosition/utils.jl 22.22% <ø> (ø)
src/Blocks/math.jl 100.00% <100.00%> (+5.00%) ⬆️
src/Blocks/sources.jl 65.38% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ven-k
Copy link
Member Author

ven-k commented Sep 4, 2023

[See revised conclusions below]
Error with invalidations test seem to be sporadic.
MSL fails to precompile in the Invalidations test; while it precompiles and passes unit-tests.
I couldn't recreate the error locally for this snippet1.
Re-running it might just pass it.

Note that the error

ERROR: LoadError: syntax: function argument name not unique: "y_start" around /home/runner/work/ModelingToolkitStandardLibrary.jl/ModelingToolkitStandardLibrary.jl/src/Blocks/nonlinear.jl:77

shouldn't appear for this branch. y_start has been removed from @parametersblock ofSlewRateLimiter` here2.
It appears to be some caching issue; however, even after digging through the logs I couldn't find any evidence for that

Footnotes

  1. https://github.com/SciML/ModelingToolkitStandardLibrary.jl/actions/runs/6075562148/job/16481994939#step:8:64

  2. https://github.com/SciML/ModelingToolkitStandardLibrary.jl/pull/209/files#diff-4c7a873472d2ebf3629882dc4228cc2de7a094396b71f42ef05f1a4bbd1805e7R107~

@ven-k ven-k force-pushed the vkb/extend-kwargs branch from ec7a52c to 3f63e66 Compare September 5, 2023 03:30
@ven-k
Copy link
Member Author

ven-k commented Sep 5, 2023

In the invalidations test, this branch successfully precompiles- see1.
However it is the default branch (against which invalidations count is taken), fails to precompile. That should be expected with [email protected] and this PR is meant to fix the errors like:

ERROR: LoadError: syntax: function argument name not unique: "y_start" around /home/runner/work/ModelingToolkitStandardLibrary.jl/ModelingToolkitStandardLibrary.jl/src/Blocks/nonlinear.jl:77

So this PR can be merged.

Footnotes

  1. https://github.com/SciML/ModelingToolkitStandardLibrary.jl/actions/runs/6079874565/job/16492986525#step:5:292

@baggepinnen baggepinnen merged commit 93fb122 into SciML:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants