-
-
Notifications
You must be signed in to change notification settings - Fork 46
refactor: kwargs of base system are now kwargs of main component #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
97b3b83 to
a8021bd
Compare
…nLinearity`, `TimeVaryingFunction`
dfecae8 to
2ca7936
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a bound on MTK as well.
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 55.00% 55.10% +0.10%
==========================================
Files 48 48
Lines 1620 1617 -3
==========================================
Hits 891 891
+ Misses 729 726 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
[See revised conclusions below]
Footnotes
|
ec7a52c to
3f63e66
Compare
|
In the invalidations test, this branch successfully precompiles- see1. ERROR: LoadError: syntax: function argument name not unique: "y_start" around /home/runner/work/ModelingToolkitStandardLibrary.jl/ModelingToolkitStandardLibrary.jl/src/Blocks/nonlinear.jl:77So this PR can be merged. Footnotes |
use_supportis by defaultfalseeverywhere.