Skip to content

Conversation

@Weetbix
Copy link

@Weetbix Weetbix commented Dec 17, 2020

This PR adds the usual PR quality checks.

  • Code quality
    • Runs eslint. Fails for now because we have not fixed the lint issues
  • Tests + Coverage
    • Comments on its own PRs with its own action 😎
  • Build
    • Runs build to ensure the build is successful
    • Checks that the committed dist has no differences to the one it build during CI. This allows us to ensure that you ran build and committed the dist file locally.
    • In the future we can discuss how the build dist file should be, and if it should be moved into CI only instead of being committed. But at this point it makes the PRs a bit safer :)

Changes:

  • Had to delete and recreate the yarn lock file, as tests were failing to run with the previously resolved tree
  • Ignored the dist file in prettier ignore
  • Updated the jest test file name config. Forgot to do this in the ESLint PR so tests were not picked up
  • Updated the dist, as there are changes due to the lock file changes

@github-actions
Copy link

github-actions bot commented Dec 17, 2020

Coverage after merging jh/add-gh-action-check-to-pr into master

100.00%
Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   html.js100%100%100%
   lcov.js100%100%100%
   tabulate.js100%100%100%

@Weetbix Weetbix changed the title [DRAFT] Add gh actions PR checks [DRAFT] Add GH Actions PR checks Dec 17, 2020
@Weetbix Weetbix marked this pull request as ready for review December 17, 2020 11:38
@Weetbix Weetbix changed the title [DRAFT] Add GH Actions PR checks Add GH Actions PR checks Dec 17, 2020
Copy link

@eeshdarthvader eeshdarthvader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff 🔥

@Weetbix Weetbix merged commit 2c2f175 into master Dec 17, 2020
@Weetbix Weetbix deleted the jh/add-gh-action-check-to-pr branch December 17, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants