Skip to content

Conversation

konnng-dev
Copy link
Contributor

This pull request improves error handling when removing directories during FTP operations. In certain cases, the target directory may already be unavailable (e.g., deleted, renamed, or removed by a build process). Instead of throwing an exception, the process now logs a warning informing the user that the directory could not be removed or accessed.

This approach ensures that the state file remains in sync and avoids breaking deployments that rely on the SamKirkland/FTP-Deploy-Action GitHub Action.

Summary of Changes

  • Improved Error Handling:
    • Replaces exceptions with warnings when directories cannot be removed.
  • Deployment Reliability:
    • Keeps the state file consistent even if some directories are missing.
    • Prevents deployments from failing due to non-critical directory removal issues.

@SamKirkland
Copy link
Owner

Thanks for the pull request!
Looks good & makes sense to me!

Copy link
Owner

@SamKirkland SamKirkland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change.
Thanks a bunch for the PR!

@juliovedovatto
Copy link

juliovedovatto commented Aug 25, 2025

Hi @SamKirkland

Thank you so much for the fast review. I addressed your comment and sent an update. Could you check again?

@SamKirkland SamKirkland self-requested a review August 25, 2025 18:30
Copy link
Owner

@SamKirkland SamKirkland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@SamKirkland SamKirkland merged commit 8ab5e9e into SamKirkland:master Aug 25, 2025
@SamKirkland
Copy link
Owner

I will need to release a new version of the NPM package & update the action as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants