Skip to content

chore: add node 24 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025
Merged

chore: add node 24 #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c68c51
chore: add node 24 to build
o-liver Jun 12, 2025
c4788c9
chore: release node 24
o-liver Jun 12, 2025
6eba147
Merge branch 'master' into node24
o-liver Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
base-image-tag: [20-bookworm, 22-bookworm]
base-image-tag: [20-bookworm, 22-bookworm, 24-bookworm]
steps:
- uses: actions/checkout@master
- name: Determine Java version
Expand All @@ -28,7 +28,7 @@ jobs:
docker build --build-arg=BASE_IMAGE_TAG=${{ matrix.base-image-tag }} --build-arg=JAVA_VERSION=${{ steps.java_version.outputs.version }} --tag ppiper/node-browsers:${{ matrix.base-image-tag }} .
docker tag ppiper/node-browsers:${{ matrix.base-image-tag }} ghcr.io/sap/ppiper-node-browsers:${{ matrix.base-image-tag }}
- name: Tag latest image
if: ${{ matrix.base-image-tag == '22-bookworm' }}
if: ${{ matrix.base-image-tag == '24-bookworm' }}
run: |
docker tag ppiper/node-browsers:${{ matrix.base-image-tag }} ppiper/node-browsers:latest
docker tag ghcr.io/sap/ppiper-node-browsers:${{ matrix.base-image-tag }} ghcr.io/sap/ppiper-node-browsers:latest
Expand All @@ -39,7 +39,7 @@ jobs:
echo "${{ secrets.CR_PAT }}" | docker login https://ghcr.io -u ${{ secrets.CR_USER }} --password-stdin
docker push ppiper/node-browsers:${{ matrix.base-image-tag }}
docker push ghcr.io/sap/ppiper-node-browsers:${{ matrix.base-image-tag }}
if [ "${{ matrix.base-image-tag }}" == 22-bookworm ]; then
if [ "${{ matrix.base-image-tag }}" == 24-bookworm ]; then
docker push ppiper/node-browsers:latest
docker push ghcr.io/sap/ppiper-node-browsers:latest
fi
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
base-image-tag: [20-bookworm, 22-bookworm]
base-image-tag: [20-bookworm, 22-bookworm, 24-bookworm]
steps:
- uses: actions/checkout@v3
- name: Determine Java version
Expand Down Expand Up @@ -44,15 +44,15 @@ jobs:
docker tag ppiper/node-browsers:${{ env.PIPER_version }}-${{ matrix.base-image-tag }} ghcr.io/sap/ppiper-node-browsers:${{ env.PIPER_version }}-${{ matrix.base-image-tag }}
docker push ppiper/node-browsers:${{ env.PIPER_version }}-${{ matrix.base-image-tag }}
docker push ghcr.io/sap/ppiper-node-browsers:${{ env.PIPER_version }}-${{ matrix.base-image-tag }}
- name: Tag and push node 22 image
if: ${{ matrix.base-image-tag == '22-bookworm' }}
- name: Tag and push node 24 image
if: ${{ matrix.base-image-tag == '24-bookworm' }}
run: |
docker tag ppiper/node-browsers:${{ env.PIPER_version }}-${{ matrix.base-image-tag }} ppiper/node-browsers:${{ env.PIPER_version }}
docker tag ghcr.io/sap/ppiper-node-browsers:${{ env.PIPER_version }}-${{ matrix.base-image-tag }} ghcr.io/sap/ppiper-node-browsers:${{ env.PIPER_version }}
docker push ppiper/node-browsers:${{ env.PIPER_version }}
docker push ghcr.io/sap/ppiper-node-browsers:${{ env.PIPER_version }}
- uses: SAP/project-piper-action@master
if: ${{ matrix.base-image-tag == '22-bookworm' }}
if: ${{ matrix.base-image-tag == '24-bookworm' }}
with:
piper-version: latest
command: githubPublishRelease
Expand Down