chore: Add note to Release PR #918
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonas-Isr
commented
Sep 1, 2025
| - [ ] Trigger the [Perform Release Workflow](${{ github.event.repository.html_url }}/actions/workflows/perform-release.yml) | ||
| - [ ] Once the `Perform Release` workflow is through, head over to [Central Sonatype](https://central.sonatype.com/publishing/deployments) and log in with the credentials in the Team Password Safe. There should be a published release.") | ||
| - [ ] Once all tests of this PR are green, trigger the [Perform Release Workflow](${{ github.event.repository.html_url }}/actions/workflows/perform-release.yml) | ||
| - [ ] Once the `Perform Release` workflow is through, head over to [Central Sonatype](https://central.sonatype.com/publishing/deployments) and log in with the credentials in the Team Password Safe. There should be a validated release that can be released by clicking the _release_ button.") |
There was a problem hiding this comment.
I added the bottom note (and did not set the release process to autopublish as we have for AI SDK) to make sure we do not end up in a scenario were we release a version on Maven central but the Gh workflow fails to merge the PRs afterwards, leaving us in an incomplete state.
I am not 100% happy with this approach and would appreciate some feedback.
CharlesDuboisSAP
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
If the Perform Release workflow is triggered so early that the CI workflow of the release PR is not yet green, the Perform Release workflow will fail after the deployment of our code but before merging all the PRs.
This PR adds a note to the release PR to not trigger the Perform Release workflow too early.
Feature scope:
Definition of Done
Tests cover the scope aboveError handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated