der: Document and SecretDocument types
#571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
der/document-types
branch
4 times, most recently
from
ce80f42 to
156e8a4
Compare
tarcieri
force-pushed
the
der/document-types
branch
2 times, most recently
from
d4da146 to
7e991f5
Compare
tarcieri
changed the title
Document and SecretDocument typesDocument and SecretDocument types
This was referenced Apr 3, 2022
tarcieri
force-pushed
the
der/document-types
branch
from
7e991f5 to
933122e
Compare
|
Removing WIP/draft. The core implementation is effectively done, although could probably use some additional work to reduce repetitiveness. Still, this removes quite a bit of duplicated code from the original implementation. I'm going to continue adding additional/replacement tests for the format-specific |
tarcieri
force-pushed
the
der/document-types
branch
from
933122e to
3d998bc
Compare
tarcieri
commented
Apr 3, 2022
| @@ -1,97 +0,0 @@ | |||
| //! CertificateDocument implementation | |||
There was a problem hiding this comment.
@carl-wallace FYI, ended up removing this along with all of the format-specific *Document types. Hope the Document type works for your use cases
tarcieri
force-pushed
the
der/document-types
branch
3 times, most recently
from
bf3ca08 to
4ad135f
Compare
Replaces the previous `Document` trait with types for wrapping serialized ASN.1 DER SEQUENCEs stored on the heap. The `SecretDocument` is composed in terms of `Document` and provides some additional hardening for sensitive data, namely zeroize-on-drop and file permissions hardening when writing to disk. This commit also removes all of the format-specific `*Document` types found in the `pkcs1`, `pkcs8`, `spki`, and `sec1` crates with the new `Document` and `SecretDocument` types.
tarcieri
force-pushed
the
der/document-types
branch
from
4ad135f to
7104154
Compare
This was referenced May 8, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the previous
Documenttrait with types for wrapping serialized ASN.1 DER SEQUENCEs stored on the heap.The
SecretDocumentis composed in terms ofDocumentand provides some additional hardening for sensitive data, namely zeroize-on-drop and file permissions hardening when writing to disk.This commit also removes all of the format-specific
*Documenttypes found in thepkcs1,pkcs8,spki, andsec1crates with the newDocumentandSecretDocumenttypes.